Paul Berry
c4f7afa401
This is the first in a series of two CLs that will change the class `ExpressionPropertyTarget` so that instead of looking up the target's expression info during the call to `_getSsaNode`, it is given the expression info at the time it is constructed. This will help simplify the flow analysis API, by removing the need for it to know about the `Expression` types used by the client. In this first CL, an `expressionInfo` field is added to `ExpressionPropertyTarget`, but the old `expression` field is not yet removed. At the time `_getSsaNode` is called, it looks up the expression info and double checks (using an assertion) that it's the same as what is stored in its `expressionInfo` field. Once this change has passed trybots, I'll follow up with the second CL in the series, which will remove the `expression` field. The reason I've split this into two CLs is that I've discovered that at least one call site needed to have its logic reordered, to make sure that it didn't try to call `getExpressionInfo` too early. Before I proceed with the second CL, I want to see a full trybot run with the assertion in place, to verify that the expression infos supplied to `ExpressionPropertyTarget` are correct. Change-Id: I6a6a69641bf8779743dda4e74ec6adbeac0ee2d6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/480600 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.