Ryan Macnak
f0b2a46734
Fuchsia is about to turn on ShadowCallStack for ARM64. Once this is enabled, we need to treat R18 like a preserved register. Generated Dart has not accessed this register because it is reserved on iOS, and in the absence of Dart exceptions this would be sufficient for us to be ShadowCallStack compatible. However, our exception handling mechanism jumps past all the C++ frames between the Dart exit frame and Exceptions::JumpToFrame, skipping code that would pop from R18. Add save/restore of R18 in the invocation stubs, and restore of R18 in the jump stub. The latter prevents the ShadowCallStack from overflowing for code that has lots of exceptions without a native call. Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=37449 Change-Id: I2ce6e46624c8d72507e7afa7a44839b1f0def556 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119481 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
73 lines
2.7 KiB
C++
73 lines
2.7 KiB
C++
// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_VM_STACK_FRAME_ARM64_H_
|
|
#define RUNTIME_VM_STACK_FRAME_ARM64_H_
|
|
|
|
#if !defined(RUNTIME_VM_STACK_FRAME_H_)
|
|
#error Do not include stack_frame_arm64.h directly; use stack_frame.h instead.
|
|
#endif
|
|
|
|
namespace dart {
|
|
|
|
/* ARM64 Dart Frame Layout
|
|
| | <- TOS
|
|
Callee frame | ... |
|
|
| saved PP |
|
|
| code object |
|
|
| saved FP | (FP of current frame)
|
|
| saved PC | (PC of current frame)
|
|
+--------------------+
|
|
Current frame | ... T| <- SP of current frame
|
|
| first local T|
|
|
| caller's PP T|
|
|
| code object T| (current frame's code object)
|
|
| caller's FP | <- FP of current frame
|
|
| caller's LR | (PC of caller frame)
|
|
+--------------------+
|
|
Caller frame | last parameter | <- SP of caller frame
|
|
| ... |
|
|
|
|
T against a slot indicates it needs to be traversed during GC.
|
|
*/
|
|
|
|
static const int kDartFrameFixedSize = 4; // PP, FP, LR, PC marker.
|
|
static const int kSavedPcSlotFromSp = -1;
|
|
|
|
static const int kFirstObjectSlotFromFp = -1; // Used by GC to traverse stack.
|
|
static const int kLastFixedObjectSlotFromFp = -2;
|
|
|
|
static const int kFirstLocalSlotFromFp = -3;
|
|
static const int kSavedCallerPpSlotFromFp = -2;
|
|
static const int kPcMarkerSlotFromFp = -1;
|
|
static const int kSavedCallerFpSlotFromFp = 0;
|
|
static const int kSavedCallerPcSlotFromFp = 1;
|
|
|
|
static const int kParamEndSlotFromFp = 1; // One slot past last parameter.
|
|
static const int kCallerSpSlotFromFp = 2;
|
|
static const int kLastParamSlotFromEntrySp = 0;
|
|
|
|
// Entry and exit frame layout.
|
|
#if defined(TARGET_OS_FUCHSIA)
|
|
static const int kExitLinkSlotFromEntryFp = -23;
|
|
COMPILE_ASSERT(kAbiPreservedCpuRegCount == 11);
|
|
#else
|
|
static const int kExitLinkSlotFromEntryFp = -22;
|
|
COMPILE_ASSERT(kAbiPreservedCpuRegCount == 10);
|
|
#endif
|
|
COMPILE_ASSERT(kAbiPreservedFpuRegCount == 8);
|
|
|
|
// For FFI native -> Dart callbacks, this is the number of stack slots between
|
|
// arguments passed on stack and arguments saved in callback prologue.
|
|
//
|
|
// 2 = return adddress (1) + saved frame pointer (1).
|
|
//
|
|
// If NativeCallbackTrampolines::Enabled(), then
|
|
// kNativeCallbackTrampolineStackDelta must be added as well.
|
|
constexpr intptr_t kCallbackSlotsBeforeSavedArguments = 2;
|
|
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_VM_STACK_FRAME_ARM64_H_
|