Ömer Sinan Ağacan
d46aa63099
Some other changes: - Variable `id` renamed to `classId` in a few places. In this code there are two types of IDs: class IDs and selector IDs, and they have the same type. So just "id" is ambiguous to the reader. - `SelectorInfo.sortWeight` and `SelectorInfo.isAlive` getters moved to `DispatchTable.build` as local functions - Most of the members are made private. - List of selector IDs of a class is now a Set. These lists used to have duplicate selector IDs coming from superclasses. - `DynamicDispatcher.maybeCalledDynamically` special case for `noSuchMethod` moved to `SelectorInfo.isAlive`, as the only reason why we had that special case is to keep selector for `noSuchMethod` alive. `maybeCalledDynamically` inlined in the use site. Change-Id: Iff650862d57e376913bda67db74bc67466d45e87 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/269461 Reviewed-by: Aske Simon Christensen <askesc@google.com> Reviewed-by: Joshua Litt <joshualitt@google.com> Commit-Queue: Ömer Ağacan <omersa@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency