Martin Kustermann
06b2967188
The main purpose of the low-level [PortMap] is to coordinate between ports being opened & closed and concurrent message senders. That's the only thing it should do. Each isolate owns [ReceivePort]s. Only the isolate mutator can create ports, delete them or change their "keeps-isolate-alive" state. Right now it requires going via [PortMap] (which acquires lock) and [MessageHandler] (which acquires lock) to change the "keeps-isolate-alive" state of a port. We'll move information whether a dart [ReceivePort] is closed and whether it keeps the isolate alive into the [ReceivePort] object itself. => Changing the "keeps-isolate-alive" state of the port no longer requires any locks. We could even avoid the runtime call itself in a future CL. Isolates are kept alive if there's any open receive ports (that have not been marked as "does not keep isolate alive"). This is a property of an isolate not of the message handler. For native message handlers we do have a 1<->1 correspondence between port and handler (i.e. there's no "number of open ports" tracking needed). => We'll move the logic of counting open receive ports and ports that keep the isolate alive to the [Isolate]. => We'll also remove locking around incrementing/decrementing or accessing the counts. => The [IsolateMessageHandler] will ask the [Isolate] whether there's any open ports for determining whether to shut down. => For native ports, the `Dart_NewNativePort()` & `Dart_CloseNativePort()` functions will manage the lifetime (as their name also suggests). Overall this makes the [Isolate] responsible for creation of dart [ReceivePort]s and tracking whether the isolate should be kept alive: * Isolate::CreateReceivePort() * Isolate::SetReceivePortKeepAliveState() * Isolate::CloseReceivePort() TEST=ci Change-Id: I847ae357c26254d3810cc277962e05deca18a1de Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/317960 Reviewed-by: Alexander Aprelev <aam@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
47 lines
1.3 KiB
C++
47 lines
1.3 KiB
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/native_message_handler.h"
|
|
|
|
#include <memory>
|
|
|
|
#include "vm/dart_api_message.h"
|
|
#include "vm/isolate.h"
|
|
#include "vm/message.h"
|
|
#include "vm/message_snapshot.h"
|
|
#include "vm/snapshot.h"
|
|
|
|
namespace dart {
|
|
|
|
NativeMessageHandler::NativeMessageHandler(const char* name,
|
|
Dart_NativeMessageHandler func)
|
|
: name_(Utils::StrDup(name)), func_(func) {}
|
|
|
|
NativeMessageHandler::~NativeMessageHandler() {
|
|
free(name_);
|
|
}
|
|
|
|
#if defined(DEBUG)
|
|
void NativeMessageHandler::CheckAccess() const {
|
|
ASSERT(Isolate::Current() == nullptr);
|
|
}
|
|
#endif
|
|
|
|
MessageHandler::MessageStatus NativeMessageHandler::HandleMessage(
|
|
std::unique_ptr<Message> message) {
|
|
if (message->IsOOB()) {
|
|
// We currently do not use OOB messages for native ports.
|
|
UNREACHABLE();
|
|
}
|
|
// We create a native scope for handling the message.
|
|
// All allocation of objects for decoding the message is done in the
|
|
// zone associated with this scope.
|
|
ApiNativeScope scope;
|
|
Dart_CObject* object = ReadApiMessage(scope.zone(), message.get());
|
|
(*func())(message->dest_port(), object);
|
|
return kOK;
|
|
}
|
|
|
|
} // namespace dart
|