Sam Rawlins
3b648e4635
Fixes https://github.com/dart-lang/sdk/issues/54038 The main feature is a small expansion to what is allowed in the `flutter / assets` field. We used to enforce that the `assets` field is a list, and that each value is a string. Now we enforce that: * the `assets` field is a list * an asset is either a string, or * an asset is a map, with at least a 'path' key, with a string value. This requires deprecating the `ASSET_NOT_STRING` code, and introducing three others: * ASSET_MISSING_PATH * ASSET_NOT_STRING_OR_MAP * ASSET_PATH_NOT_STRING In addition I cleaned up a UX issue: Several codes referenced an 'asset' key, but it should be 'assets'. (In addition, the `ASSET_FIELD_NOT_LIST` code should be `ASSETS_FIELD_NOT_LIST` but I did not fix that.) I also refactored all of the code to be more modern: * Use `var` instead of types in declarations * Short circuit error-and-return with `if (foo is! YamlMap)`. We didn't use to have promotion here, but this led to a wild amount of nesting (if, if, for, if, if, else, if!). Change-Id: Ia489ea631f7d1027fdb84a9a682c831752c5835c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338593 Reviewed-by: Marya Belanger <mbelanger@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
SDK development code analysis
dartanalyzer used to be the tool for statically analyzing dart code
at the command line. However, this tool has been replaced with
dart analyze for this purpose in current SDKs and will no longer
be published on pub.
Do not depend on the command line interface or other semantics in
this directory as it is now an internal tool for SDK development, used
as the dart2analyzer "compiler" for tools/test.py in the SDK.
It is configured as part of the test runner,
here.
SDK development usage
For SDK development, run analysis from the test tool to validate analysis conclusions on language samples in the testing directory. From the root of the SDK:
tools/test.py --build --use-sdk -c dart2analyzer co19 language
This will build the Dart VM and compile dartanalyzer into a snapshot, then use
that snapshot while analyzing those directories under testing/. Without
--use-sdk, test.py will use the source code version of the analyzer
instead of the compiled one, which can be useful for debugging.