Files
sdk/pkg/analyzer_plugin/lib/src
Brian Wilkerson df964d1c1a Fix a bug in OpType that caused it to compute the wrong completion location
Looking atanges to the tests I wasn't sure whether this was a good change
to make, but the metrics improve for both locations as a result:

CompilationUnit_declaration                   64.159  |     58.277     -5.882
CompilationUnit_directive                   Infinity  |     88.826  -Infinity

The tests mostly cover the case where insertion is between the two, and in
those cases we might want a blend of the two because it's impossible to know
whether the user is adding a directive after the last directive or adding
a declarartion before the first declaration. But that's a topic for a
different CL.

Change-Id: I2b82209ab77796d0bc8b9fc4a7c0ab91293c3746
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211083
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2021-08-25 00:45:35 +00:00
..