Konstantin Shcheglov a900531934 Don't read files in _isPackageReference() during MoveFileRefactoringImpl. ...

We regularly get FileSystemException(s) like:
at _PhysicalFile.readAsStringSync (physical_file_system.dart:184)
at _OverlayFile.readAsStringSync (overlay_file_system.dart:206)
at FileSource.contentsFromFile (source_resource.dart:68)
at FileSource.contents (source_resource.dart:55)
at MoveFileRefactoringImpl._isPackageReference (move_file.dart:183)

So, instead we could use already recorded source content from which
the element model was built.

Alternatively we could record different kinds of references into
the index, e.g. IS_REFERENCED_BY_PACKAGE_URI or IS_REFERENCED_BY.

Change-Id: Ic4aa839f706f37c9df2504f866dfca7c7581c347
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

2021-09-09 15:32:03 +00:00

..

lsp_protocol

analysis_server: migrate to Object.hash functions

2021-09-09 00:23:43 +00:00

plugin

Add a quick fix to import extensions when members are referenced

2021-06-01 23:28:25 +00:00

protocol

Remove support for the deprecated dartfix tool

2021-07-02 18:30:24 +00:00

src

Don't read files in _isPackageReference() during MoveFileRefactoringImpl.

2021-09-09 15:32:03 +00:00

starter.dart

Migrate all remaining server libraries except the library in bin

2021-04-24 04:19:22 +00:00