Paul Berry
8b66930364
Previously, in the `CheckSorted` presubmit check, if
`verify_sorted_test.dart` returned a nonzero exit code but none of its
output lines contained the string `Unsorted file`, then a presubmit
failure would be generated containing an empty string, resulting in
confusing output like this:
Running presubmit upload checks ...
18.4s to run CheckChangeOnUpload from /home/paulberry/dart1/sdk/pkg/_fe_analyzer_shared/PRESUBMIT.py.
** Presubmit ERRORS: 1 **
Presubmit checks took 21.4s to calculate.
There were presubmit errors.
This might happen, for example, if `verify_sorted_test.dart` contained
a compile-time error or threw an unhandled exception.
With this change, the message is `CheckSorted: could not parse output
of verify_sorted_test.dart`, followed by the full stdout and stderr
from the attempt.
This should make this sort of failure a lot easier to debug.
Note: I've made this same fix before to
`pkg/_fe_analyzer_shared/PRESUBMIT.py` (see
https://dart-review.googlesource.com/c/sdk/+/485601). I didn't realize
at the time that the code was duplicated.
Note: This should make it easier to debug
https://github.com/dart-lang/sdk/issues/63464.
Change-Id: I4892dcff7ad6969ca40564c1fd7e62e36a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/506605
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
SDK development code analysis
dartanalyzer used to be the tool for statically analyzing dart code
at the command line. However, this tool has been replaced with
dart analyze for this purpose in current SDKs and will no longer
be published on pub.
Do not depend on the command line interface or other semantics in
this directory as it is now an internal tool for SDK development, used
as the dart2analyzer "compiler" for tools/test.py in the SDK.
It is configured as part of the test runner,
here.
SDK development usage
For SDK development, run analysis from the test tool to validate analysis conclusions on language samples in the testing directory. From the root of the SDK:
tools/test.py --build --use-sdk -c dart2analyzer co19 language
This will build the Dart VM and compile dartanalyzer into a snapshot, then use
that snapshot while analyzing those directories under testing/. Without
--use-sdk, test.py will use the source code version of the analyzer
instead of the compiled one, which can be useful for debugging.