Paul Berry
bcd7c3a3e4
In a follow-up CL, I will change the code generator for diagnostic messages so that all code-generated instances of `DiagnosticCode` have `name` and `uniqueName` fields in all lower case letters. This will help pave the way toward resolving conflicts between the diagnostic code naming conventions between the analyzer and CFE. To prepare for this change, the following pieces of code need to first be modified to be case insensitive: - The `_ignoreNullSafetyWarnings` check in `RemoveDeadCodeSoundFlowAnalysisTest`. - The `_diagnosticCodes` fields in `_CannotIgnoreOptionValidator` and `_ErrorFilterOptionValidator`. - The `computeErrorData` methods in `ConstantsDataComputer` and `_InheritanceDataComputer`. - The `_writeDiagnostic` methods in `DriverEventsPrinter` and `ResolvedUnitResultPrinter`. - The `_validateMessages` and `_validateSnippet` methods in `DocumentationValidator`. - The `run` method in `TextualOutline`. In most cases, the code was changed to be case insensitive by having it call `.toLowerCase()` or `.toUpperCase()` on the diagnostic code name before operating on it. In one case I was able to re-use the `AnalyzerCode.lowerSnakeCaseName` getter. Change-Id: I6a6a6964f3cc4c71f2e82478855d64d5ef91d26b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465804 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.