Vyacheslav Egorov
f496e538f4
This is the next step towards preventing compiler from directly peeking into runtime and instead interact with runtime through a well defined surface. The goal of the refactoring to locate all places where compiler accesses some runtime information and partion those accesses into two categories: - creating objects in the host runtime (e.g. allocating strings, numbers, etc) during compilation; - accessing properties of the target runtime (e.g. offsets of fields) to embed those into the generated code; This change introduces dart::compiler and dart::compiler::target namespaces. All code in the compiler will gradually be moved into dart::compiler namespace. One of the motivations for this change is to be able to prevent access to globally defined host constants like kWordSize by shadowing them in the dart::compiler namespace. The nested namespace dart::compiler::target hosts all information about target runtime that compiler could access, e.g. compiler::target::kWordSize defines word size of the target which will eventually be made different from the host kWordSize (defined by dart::kWordSize). The API for compiler to runtime interaction is placed into compiler_api.h. Note that we still permit runtime to access compiler internals directly - this is not going to be decoupled as part of this work. Issue https://github.com/dart-lang/sdk/issues/31709 Change-Id: If4396d295879391becfa6c38d4802bbff81f5b20 Reviewed-on: https://dart-review.googlesource.com/c/90242 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
92 lines
2.4 KiB
C++
92 lines
2.4 KiB
C++
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_VM_HEAP_VERIFIER_H_
|
|
#define RUNTIME_VM_HEAP_VERIFIER_H_
|
|
|
|
#include "vm/flags.h"
|
|
#include "vm/globals.h"
|
|
#include "vm/handle_visitor.h"
|
|
#include "vm/handles.h"
|
|
#include "vm/thread.h"
|
|
#include "vm/visitor.h"
|
|
|
|
namespace dart {
|
|
|
|
// Forward declarations.
|
|
class Isolate;
|
|
class ObjectSet;
|
|
class RawObject;
|
|
|
|
enum MarkExpectation { kForbidMarked, kAllowMarked, kRequireMarked };
|
|
|
|
class VerifyObjectVisitor : public ObjectVisitor {
|
|
public:
|
|
VerifyObjectVisitor(Isolate* isolate,
|
|
ObjectSet* allocated_set,
|
|
MarkExpectation mark_expectation)
|
|
: isolate_(isolate),
|
|
allocated_set_(allocated_set),
|
|
mark_expectation_(mark_expectation) {}
|
|
|
|
virtual void VisitObject(RawObject* obj);
|
|
|
|
private:
|
|
Isolate* isolate_;
|
|
ObjectSet* allocated_set_;
|
|
MarkExpectation mark_expectation_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(VerifyObjectVisitor);
|
|
};
|
|
|
|
// A sample object pointer visitor implementation which verifies that
|
|
// the pointers visited are contained in the isolate heap.
|
|
class VerifyPointersVisitor : public ObjectPointerVisitor {
|
|
public:
|
|
explicit VerifyPointersVisitor(Isolate* isolate, ObjectSet* allocated_set)
|
|
: ObjectPointerVisitor(isolate), allocated_set_(allocated_set) {}
|
|
|
|
virtual void VisitPointers(RawObject** first, RawObject** last);
|
|
|
|
static void VerifyPointers(MarkExpectation mark_expectation = kForbidMarked);
|
|
|
|
private:
|
|
ObjectSet* allocated_set_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(VerifyPointersVisitor);
|
|
};
|
|
|
|
class VerifyWeakPointersVisitor : public HandleVisitor {
|
|
public:
|
|
explicit VerifyWeakPointersVisitor(VerifyPointersVisitor* visitor)
|
|
: HandleVisitor(Thread::Current()), visitor_(visitor) {}
|
|
|
|
virtual void VisitHandle(uword addr);
|
|
|
|
private:
|
|
ObjectPointerVisitor* visitor_;
|
|
|
|
ObjectSet* allocated_set;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(VerifyWeakPointersVisitor);
|
|
};
|
|
|
|
#if defined(DEBUG)
|
|
class VerifyCanonicalVisitor : public ObjectVisitor {
|
|
public:
|
|
explicit VerifyCanonicalVisitor(Thread* thread);
|
|
virtual void VisitObject(RawObject* obj);
|
|
|
|
private:
|
|
Thread* thread_;
|
|
Instance& instanceHandle_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(VerifyCanonicalVisitor);
|
|
};
|
|
#endif // defined(DEBUG)
|
|
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_VM_HEAP_VERIFIER_H_
|