Samir Jindel
f03ddc496b
Instead, we set a bit on force-optimized code so that deoptimization knows to skip it and exception handling will execute catch-entry moves. In addition we don't throw away deoptimization info for these codes, so that exception handling works. Bug: dartbug.com/37311 Change-Id: If5bcff41a98c0053c581648a9ee22b3302ceea04 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106740 Commit-Queue: Samir Jindel <sjindel@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
73 lines
2.7 KiB
C++
73 lines
2.7 KiB
C++
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_VM_COMPILER_BACKEND_FLOW_GRAPH_CHECKER_H_
|
|
#define RUNTIME_VM_COMPILER_BACKEND_FLOW_GRAPH_CHECKER_H_
|
|
|
|
#if !defined(DART_PRECOMPILED_RUNTIME)
|
|
#if defined(DEBUG)
|
|
|
|
#include "vm/compiler/backend/flow_graph.h"
|
|
#include "vm/compiler/backend/il.h"
|
|
|
|
namespace dart {
|
|
|
|
// Class responsible for performing sanity checks on the flow graph.
|
|
// The intended use is running the checks after each compiler pass
|
|
// in debug mode in order to detect graph inconsistencies as soon
|
|
// as possible. This way, culprit passes are more easily identified.
|
|
//
|
|
// All important assumptions on the flow graph structure that can be
|
|
// verified in reasonable time should be made explicit in this pass
|
|
// so that we no longer rely on asserts that are dispersed throughout
|
|
// the passes or, worse, unwritten assumptions once agreed upon but
|
|
// so easily forgotten. Since the graph checker runs only in debug
|
|
// mode, it is acceptable to perform slightly elaborate tests.
|
|
class FlowGraphChecker : public FlowGraphVisitor {
|
|
public:
|
|
// Constructs graph checker. The checker uses some custom-made
|
|
// visitation to perform additional checks, and uses the
|
|
// FlowGraphVisitor structure for anything else.
|
|
explicit FlowGraphChecker(FlowGraph* flow_graph)
|
|
: FlowGraphVisitor(flow_graph->preorder()),
|
|
flow_graph_(flow_graph),
|
|
current_block_(nullptr) {}
|
|
|
|
// Performs a sanity check on the flow graph.
|
|
void Check(const char* pass_name);
|
|
|
|
private:
|
|
// Custom-made visitors.
|
|
void VisitBlocks() override;
|
|
void VisitInstructions(BlockEntryInstr* block);
|
|
void VisitInstruction(Instruction* instruction);
|
|
void VisitDefinition(Definition* def);
|
|
void VisitUseDef(Instruction* instruction,
|
|
Value* use,
|
|
intptr_t index,
|
|
bool is_env);
|
|
void VisitDefUse(Definition* def, Value* use, Value* prev, bool is_env);
|
|
|
|
// Instruction visitors.
|
|
void VisitConstant(ConstantInstr* constant) override;
|
|
void VisitPhi(PhiInstr* phi) override;
|
|
void VisitGoto(GotoInstr* jmp) override;
|
|
void VisitIndirectGoto(IndirectGotoInstr* jmp) override;
|
|
void VisitBranch(BranchInstr* branch) override;
|
|
void VisitRedefinition(RedefinitionInstr* def) override;
|
|
void VisitInstanceCall(InstanceCallInstr* instr) override;
|
|
void VisitPolymorphicInstanceCall(
|
|
PolymorphicInstanceCallInstr* instr) override;
|
|
|
|
FlowGraph* const flow_graph_;
|
|
BlockEntryInstr* current_block_;
|
|
};
|
|
|
|
} // namespace dart
|
|
|
|
#endif // defined(DEBUG)
|
|
#endif // !defined(DART_PRECOMPILED_RUNTIME)
|
|
|
|
#endif // RUNTIME_VM_COMPILER_BACKEND_FLOW_GRAPH_CHECKER_H_
|