Files
sdk/pkg/analysis_server/test/lsp/format_test.dart
T
Danny Tuppeny f7e288e3ad Return empty responses instead of errors for non-Dart files in LSP server
Previously we could return "invalid path" responses for any non-Dart files. This allows clients to send requests for other files and just successful (though empty) responses.

Change-Id: I192e83ac2ebd2124c03c22e3e048a066cfd33f17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101990
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
2019-05-13 09:04:36 +00:00

146 lines
3.5 KiB
Dart

// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analysis_server/src/lsp/constants.dart';
import 'package:test/test.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
import '../tool/lsp_spec/matchers.dart';
import 'server_abstract.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(FormatTest);
});
}
@reflectiveTest
class FormatTest extends AbstractLspAnalysisServerTest {
test_alreadyFormatted() async {
const contents = '''main() {
print('test');
}
''';
await initialize();
await openFile(mainFileUri, contents);
final formatEdits = await formatDocument(mainFileUri.toString());
expect(formatEdits, isNull);
}
test_formatOnType_simple() async {
const contents = '''
main ()
{
print('test');
^}
''';
final expected = '''main() {
print('test');
}
''';
await initialize();
await openFile(mainFileUri, withoutMarkers(contents));
final formatEdits = await formatOnType(
mainFileUri.toString(), positionFromMarker(contents), '}');
expect(formatEdits, isNotNull);
final formattedContents = applyTextEdits(contents, formatEdits);
expect(formattedContents, equals(expected));
}
test_invalidSyntax() async {
const contents = '''main(((( {
print('test');
}
''';
await initialize();
await openFile(mainFileUri, contents);
final formatEdits = await formatDocument(mainFileUri.toString());
expect(formatEdits, isNull);
}
test_nonDartFile() async {
await initialize();
await openFile(pubspecFileUri, simplePubspecContent);
final formatEdits =
await formatOnType(pubspecFileUri.toString(), startOfDocPos, '}');
expect(formatEdits, isNull);
}
test_path_doesNotExist() async {
await initialize();
await expectLater(
formatDocument(
new Uri.file(join(projectFolderPath, 'missing.dart')).toString()),
throwsA(isResponseError(ServerErrorCodes.InvalidFilePath)),
);
}
test_path_invalidFormat() async {
await initialize();
await expectLater(
// Add some invalid path characters to the end of a valid file:// URI.
formatDocument(mainFileUri.toString() + '***'),
throwsA(isResponseError(ServerErrorCodes.InvalidFilePath)),
);
}
test_path_notFileScheme() async {
await initialize();
await expectLater(
formatDocument('a:/a.a'),
throwsA(isResponseError(ServerErrorCodes.InvalidFilePath)),
);
}
test_simple() async {
const contents = '''
main ()
{
print('test');
}
''';
final expected = '''main() {
print('test');
}
''';
await initialize();
await openFile(mainFileUri, contents);
final formatEdits = await formatDocument(mainFileUri.toString());
expect(formatEdits, isNotNull);
final formattedContents = applyTextEdits(contents, formatEdits);
expect(formattedContents, equals(expected));
}
test_unopenFile() async {
const contents = '''
main ()
{
print('test');
}
''';
final expected = '''main() {
print('test');
}
''';
newFile(mainFilePath, content: contents);
await initialize();
final formatEdits = await formatDocument(mainFileUri.toString());
expect(formatEdits, isNotNull);
final formattedContents = applyTextEdits(contents, formatEdits);
expect(formattedContents, equals(expected));
}
}