Danny Tuppeny
f7e288e3ad
Previously we could return "invalid path" responses for any non-Dart files. This allows clients to send requests for other files and just successful (though empty) responses. Change-Id: I192e83ac2ebd2124c03c22e3e048a066cfd33f17 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101990 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Danny Tuppeny <dantup@google.com>
98 lines
2.6 KiB
Dart
98 lines
2.6 KiB
Dart
// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:analysis_server/lsp_protocol/protocol_generated.dart';
|
|
import 'package:test/test.dart';
|
|
import 'package:test_reflective_loader/test_reflective_loader.dart';
|
|
|
|
import 'server_abstract.dart';
|
|
|
|
main() {
|
|
defineReflectiveSuite(() {
|
|
defineReflectiveTests(DefinitionTest);
|
|
});
|
|
}
|
|
|
|
@reflectiveTest
|
|
class DefinitionTest extends AbstractLspAnalysisServerTest {
|
|
test_acrossFiles() async {
|
|
final mainContents = '''
|
|
import 'referenced.dart';
|
|
|
|
main() {
|
|
fo^o();
|
|
}
|
|
''';
|
|
|
|
final referencedContents = '''
|
|
/// Ensure the function is on a line that
|
|
/// does not exist in the mainContents file
|
|
/// to ensure we're translating offsets to line/col
|
|
/// using the correct file's LineInfo
|
|
/// ...
|
|
/// ...
|
|
/// ...
|
|
/// ...
|
|
/// ...
|
|
[[foo]]() {}
|
|
''';
|
|
|
|
final referencedFileUri =
|
|
Uri.file(join(projectFolderPath, 'lib', 'referenced.dart'));
|
|
|
|
await initialize();
|
|
await openFile(mainFileUri, withoutMarkers(mainContents));
|
|
await openFile(referencedFileUri, withoutMarkers(referencedContents));
|
|
final res =
|
|
await getDefinition(mainFileUri, positionFromMarker(mainContents));
|
|
|
|
expect(res, hasLength(1));
|
|
Location loc = res.single;
|
|
expect(loc.range, equals(rangeFromMarkers(referencedContents)));
|
|
expect(loc.uri, equals(referencedFileUri.toString()));
|
|
}
|
|
|
|
test_nonDartFile() async {
|
|
newFile(pubspecFilePath, content: simplePubspecContent);
|
|
await initialize();
|
|
|
|
final res = await getDefinition(pubspecFileUri, startOfDocPos);
|
|
expect(res, isEmpty);
|
|
}
|
|
|
|
test_singleFile() async {
|
|
final contents = '''
|
|
[[foo]]() {
|
|
fo^o();
|
|
}
|
|
''';
|
|
|
|
await initialize();
|
|
await openFile(mainFileUri, withoutMarkers(contents));
|
|
final res = await getDefinition(mainFileUri, positionFromMarker(contents));
|
|
|
|
expect(res, hasLength(1));
|
|
Location loc = res.single;
|
|
expect(loc.range, equals(rangeFromMarkers(contents)));
|
|
expect(loc.uri, equals(mainFileUri.toString()));
|
|
}
|
|
|
|
test_unopenFile() async {
|
|
final contents = '''
|
|
[[foo]]() {
|
|
fo^o();
|
|
}
|
|
''';
|
|
|
|
newFile(mainFilePath, content: withoutMarkers(contents));
|
|
await initialize();
|
|
final res = await getDefinition(mainFileUri, positionFromMarker(contents));
|
|
|
|
expect(res, hasLength(1));
|
|
Location loc = res.single;
|
|
expect(loc.range, equals(rangeFromMarkers(contents)));
|
|
expect(loc.uri, equals(mainFileUri.toString()));
|
|
}
|
|
}
|