My intention is to decouple LSP's Document Highlights from the legacy Occurrences implementation. Some recent changes (and one potential upcoming change) were complicated by the differences in the protocol so a separate implementation would be easier.
Along with that, IntelliJ doesn't use occurrences from the server, so it will be easier to deprecate and remove the legacy implementation if LSP is not reliant on it.
As a first step, this adds versions of all tests from `test\analysis\notification_occurrences_test.dart` that didn't already have equivalents in the LSP tests to ensure LSP still has full coverage if the implementations become separate.
Change-Id: I6b45358c812bdad8ca9611d22a27fb31027443a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/478369
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Danny Tuppeny
940b1bdbe7