Tess Strickland
0eae14f76a
Previously, the debugger used a boolean "skip next step" field that was set when a breakpoint was hit. In compiled code, not skipping the next step would cause a redundant pause to be emitted after a breakpoint, and so that field caused the next run of PauseStepping to reset it to false and then continue single stepping without the redundant pause. However, skipping only the next call to PauseStepping isn't enough when debugging bytecode. For bytecode, single stepping is performed on each bytecode instruction and so there may be multiple instructions after a breakpoint until a new token position is reached. Instead, remove the field and generalize the case being avoided by recording the token position that should be ignored and single stepping until the token position changes. This is done by recording a real last_stepping_pos_ with a last_stepping_fp_ of 0, which now means to skip any possible pauses until the token position changes. Doing this means that in each case where there are possible skips to be performed (skipping the same fp/pos after a pause, skipping the pos after a breakpoint, skipping the await fp/pos after a resumption), all such skips are handled via a single unified mechanism. This CL also reworks the kStepOut behavior so that it steps into the awaiter closest to the highest debuggable frame on the stack if there is one, not just the first awaiter even if there are no debuggable frames between that awaiter and the next. TEST=pkg/vm_service/test/vm_timeline_flags Cq-Include-Trybots: luci.dart.try:vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try Change-Id: Ic897d7bea382589751777f4db39aa58bf9525604 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/474340 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.