Danny Tuppeny a56db1a680 [dartdev] "dart language-server": Only skip --protocol=lsp if the --protocol flag is passed ...

... and not just any flag starting with "protocol".

I believe the original code used `startsWith()` to try and catch both `--protocol` as its own flag, and `--protocol=` when combined with the value. However, it also caught `--protocol-traffic-log`. `wasParsed()` should handle both of the first cases without the latter.

I also unskipped the tests for Windows because the skip was added in 44cee12ebe (Jan 2021) because the `deleteDirectory()` call failed on Windows (file locking) but f40b06a8ac (Jan 2022) already fixed that.

Fixes https://github.com/dart-lang/sdk/issues/52501

Change-Id: I931a3f12dca2683167e999e7fe59bed18159eb73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/441780
Auto-Submit: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>

2025-07-25 11:40:50 -07:00

..

src

[dartdev] "dart language-server": Only skip --protocol=lsp if the --protocol flag is passed

2025-07-25 11:40:50 -07:00

dartdev.dart

[dartdev] Organize dart --help commands into categories (2)

2025-06-25 08:39:04 -07:00