Martin Kustermann
b2171f16f1
This reverts commit b75057b687.
Reason for revert: Caused some failures on app-jit builders
Original change's description:
> [vm/concurrency] Introduce concept of Isolate Groups
>
> An Isolate Group (IG) is a collection of isolates which were spawned from the
> same source. This allows the VM to:
>
> * have a guarantee that all isolates within one IG can safely exchange
> structured objects (currently we rely on embedder for this
> guarantee)
>
> * hot-reload all isolates together (currently we only reload one
> isolate, leaving same-source isolates in inconsistent state)
>
> * make a shared heap for all isolates from the same IG, which paves
> the way for faster communication and sharing of immutable objects.
>
> All isolates within one IG will share the same IsolateGroupSource.
>
> **Embedder changes**
>
> This change makes breaking embedder API changes to support this new
> concept of Isolate Groups: The existing isolate lifecycle callbacks
> given to Dart_Initialize will become Isolate Group lifecycle callbacks.
> A new callback `initialize_isolate` callback will be added which can
> initialize a new isolate within an existing IG.
>
> Existing embedders can be updated by performing the following renames
>
> Dart_CreateIsolate -> Dart_CreateIsolateGroup
> Dart_IsolateCreateCallback -> Dart_IsolateGroupCreateCallback
> Dart_IsolateCleanupCallback -> Dart_IsolateGroupShutdownCallback
> Dart_CreateIsolateFromKernel -> Dart_CreateIsolateGroupFromKernel
> Dart_CurrentIsolateData -> Dart_CurrentIsolateGroupData
> Dart_IsolateData -> Dart_IsolateGroupData
> Dart_GetNativeIsolateData -> Dart_GetNativeIsolateGroupData
> Dart_InitializeParams.create -> Dart_InitializeParams.create_group
> Dart_InitializeParams.cleanup -> Dart_InitializeParams.shutdown_group
> Dart_InitializeParams.shutdown -> Dart_InitializeParams.shutdown_isolate
>
> By default `Isolate.spawn` will cause the creation of a new IG.
>
> Though an embedder can opt-into supporting multiple isolates within one IG by
> providing a callback to the newly added `Dart_InitializeParams.initialize_isolate`.
> The responsibility of this new callback is to initialize an existing
> isolate (which was setup by re-using source code from the spawning
> isolate - i.e. the one which used `Isolate.spawn`) by setting native
> resolvers, initializing global state, etc.
>
> Issue https://github.com/dart-lang/sdk/issues/36648
> Issue https://github.com/dart-lang/sdk/issues/36097
>
> Change-Id: I82437ac017ca33018d45e02f353b0672db155f6a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105241
> Commit-Queue: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Alexander Aprelev <aam@google.com>
TBR=kustermann@google.com,aam@google.com,rmacnak@google.com
Change-Id: Ibd90992a01d61188f27b445c21532e0c46f996ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107405
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
82 lines
2.6 KiB
C++
82 lines
2.6 KiB
C++
// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_INCLUDE_DART_EMBEDDER_API_H_
|
|
#define RUNTIME_INCLUDE_DART_EMBEDDER_API_H_
|
|
|
|
#include "dart_api.h"
|
|
#include "dart_tools_api.h"
|
|
|
|
namespace dart {
|
|
namespace embedder {
|
|
|
|
// Initialize all subsystems of the embedder.
|
|
// Returns true on success and false otherwise, in which case error would
|
|
// contain error message.
|
|
DART_WARN_UNUSED_RESULT bool InitOnce(char** error);
|
|
|
|
// Common arguments that are passed to isolate creation callback and to
|
|
// API methods that create isolates.
|
|
struct IsolateCreationData {
|
|
// URI for the main script that will be running in the isolate.
|
|
const char* script_uri;
|
|
|
|
// Advisory name of the main method that will be run by isolate.
|
|
// Only used for error messages.
|
|
const char* main;
|
|
|
|
// Isolate creation flags. Might be absent.
|
|
Dart_IsolateFlags* flags;
|
|
|
|
// Isolate callback data.
|
|
void* callback_data;
|
|
};
|
|
|
|
// Create and initialize kernel-service isolate. This method should be used
|
|
// when VM invokes isolate creation callback with DART_KERNEL_ISOLATE_NAME as
|
|
// script_uri.
|
|
// The isolate is created from the given snapshot (might be kernel data or
|
|
// app-jit snapshot).
|
|
DART_WARN_UNUSED_RESULT Dart_Isolate
|
|
CreateKernelServiceIsolate(const IsolateCreationData& data,
|
|
const uint8_t* buffer,
|
|
intptr_t buffer_size,
|
|
char** error);
|
|
|
|
// Service isolate configuration.
|
|
struct VmServiceConfiguration {
|
|
enum {
|
|
kBindHttpServerToAFreePort = 0,
|
|
kDoNotAutoStartHttpServer = -1
|
|
};
|
|
|
|
// Address to which HTTP server will be bound.
|
|
const char* ip;
|
|
|
|
// Default port. See enum above for special values.
|
|
int port;
|
|
|
|
// TODO(vegorov) document these ones.
|
|
bool dev_mode;
|
|
bool deterministic;
|
|
bool disable_auth_codes;
|
|
};
|
|
|
|
// Create and initialize vm-service isolate. This method should be used
|
|
// when VM invokes isolate creation callback with DART_VM_SERVICE_ISOLATE_NAME
|
|
// as script_uri.
|
|
// The isolate is created from the given kernel binary that is expected to
|
|
// contain all necessary vmservice libraries.
|
|
DART_WARN_UNUSED_RESULT Dart_Isolate
|
|
CreateVmServiceIsolate(const IsolateCreationData& data,
|
|
const VmServiceConfiguration& config,
|
|
const uint8_t* kernel_buffer,
|
|
intptr_t kernel_buffer_size,
|
|
char** error);
|
|
|
|
} // namespace embedder
|
|
} // namespace dart
|
|
|
|
#endif // RUNTIME_INCLUDE_DART_EMBEDDER_API_H_
|