Stephen Adams b3502f17cb [dart2js] Reduce redundant phis with refinements ...

Redundant phi elimination removes phis that join the same value.
However, this does not work when one or more of the inputs has a refinement (HTypeKnown). This change adds redundant phi elimination when the phi inputs have refinements.

The need for this optimization shows up when static js_interop needs a dispatch on type for conversion:

```
final JSAny? jsValue;
if (value is String) {
  jsValue = value.toJS;
} else if (value is bool) {
  jsValue = value.toJS;
...
```

(The `.toJS` calls become no-ops since, for dart2js, we are already in JavaScript, and so leave an otherwise pointless if-then-else chain).

Change-Id: If1a94856592163a81ac36c686cee04232c16d197
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403950
Reviewed-by: Nate Biggs <natebiggs@google.com>
Commit-Queue: Stephen Adams <sra@google.com>

2025-01-16 11:16:31 -08:00

..

data

[dart2js] Reduce redundant phis with refinements

2025-01-16 11:16:31 -08:00

model_data

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

arithmetic_simplification_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

array_static_intercept_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

bitops1_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

bitops2_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

builtin_interceptor_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

class_codegen2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

class_codegen_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

class_order_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

closure_call_of_static_reduction_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

closure_codegen_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

code_motion_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

codegen_shard0_test.dart

…

codegen_shard1_test.dart

…

codegen_test_helper.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

constant_folding_codeUnitAt_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

constant_folding_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

constant_namer_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

dead_code_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

dead_phi_eliminator_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

declare_once_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

elide_callthrough_stub_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

emit_const_fields_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

equals_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

expect_annotations2_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

expect_annotations_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

field_codegen_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

field_update_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

for_in_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

forloop_box_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

generate_at_use_site_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

generic_method_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

gvn_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

identity_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

if_do_while_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

interceptor_almost_constant_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

interceptor_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

interpolation_folding_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

inverse_operator_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

is_function_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

is_inference2_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

is_inference_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

jsarray_indexof_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

late_field_redundancy_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

late_field_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

licm_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

list_tracer_length_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

list_tracer_node_type_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

literal_list_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

literal_map_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

load_elimination_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

loop_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

minify_many_locals_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

model_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

modulo_remainder_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

negation_shift_regression_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

new_rti_is_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

no_constructor_body_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

no_duplicate_constructor_body2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

no_duplicate_constructor_body_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

no_duplicate_stub_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

null_check_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

null_type_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

number_output_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

parameter_phi_elimination_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

pragma_annotations_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

pretty_parameter_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

redundant_phi_eliminator_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

regress_10231_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

shift_right_unsigned_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

side_effect_tdiv_regression_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

simple_inferrer_relations_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

ssa_phi_codegen_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

static_closure_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

strength_eq_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

string_abbreviation_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

string_add_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

string_escapes_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

string_interpolation_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

string_reference_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

switch_empty_default_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

tdiv_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

top_level_closure_tree_shake_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

tree_shaking_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

trust_type_annotations2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

trust_type_annotations_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

type_guard_unuser_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

type_inference2_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

type_inference3_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

type_inference4_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

type_inference5_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

type_inference8_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

types_of_captured_variables_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

unused_empty_map_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

use_checks_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

use_strict_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

value_range2_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

value_range3_test.dart

Collect all test-related files in package:expect.

2024-10-11 16:53:52 +00:00

value_range_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00

variance_subtype_cast_test.dart

[dart2js] Update pubspec to Dart 3.7 and reformat.

2024-12-13 11:24:50 -08:00