ab6aeaa106
Until now we often leaked kernel buffers (e.g. hot reload buffers) because various
objects were referencing ExternalTypedData objects pointing into the middle of
c-allocated memory. This made it impossible for the GC to determine when the last
reference is gone.
This CL ensures that the actual buffers are *always* made available via
ExternalTypedData and any inner pointers into it are created via TypedDataViews.
The embedder guarantees to the free kernel buffers it has provided to:
- Dart_CreateIsolateFromKernel
- Dart_LoadScriptFromKernel
- Dart_LoadLibraryFromKernel
- Dart_SetDartLibrarySourcesKernel
on isolate shutdown.
All other kernel buffers will get a finalizer attached, which ensures the
kernel buffers get freed by the GC once they are no longer referenced:
- Kernel blobs for expression evaluation
- Kernel blobs for Hot-Reload
- Kernel blobs for cc tests
Fixes https://github.com/dart-lang/sdk/issues/33973
Fixes https://github.com/dart-lang/sdk/issues/36857
Issue https://github.com/dart-lang/sdk/issues/37030
Change-Id: I1cc410c94c0f4b229413e793728a261afcb10aaf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103130
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
223 lines
6.9 KiB
C++
223 lines
6.9 KiB
C++
// Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#ifndef RUNTIME_VM_KERNEL_H_
|
|
#define RUNTIME_VM_KERNEL_H_
|
|
|
|
#include "platform/assert.h"
|
|
#include "vm/allocation.h"
|
|
#include "vm/globals.h"
|
|
#include "vm/growable_array.h"
|
|
#include "vm/object.h"
|
|
#include "vm/token_position.h"
|
|
|
|
namespace dart {
|
|
namespace kernel {
|
|
class NameIndex {
|
|
public:
|
|
static const int kInvalidName = -1;
|
|
|
|
NameIndex() : value_(kInvalidName) {}
|
|
explicit NameIndex(int value) : value_(value) {}
|
|
|
|
operator int() const { return value_; }
|
|
|
|
private:
|
|
int value_;
|
|
};
|
|
} // namespace kernel
|
|
} // namespace dart
|
|
|
|
#if !defined(DART_PRECOMPILED_RUNTIME)
|
|
namespace dart {
|
|
|
|
class BitVector;
|
|
class Field;
|
|
class ParsedFunction;
|
|
class Zone;
|
|
|
|
namespace kernel {
|
|
|
|
class Reader;
|
|
struct ProcedureAttributesMetadata;
|
|
|
|
class StringIndex {
|
|
public:
|
|
StringIndex() : value_(-1) {}
|
|
explicit StringIndex(int value) : value_(value) {}
|
|
|
|
operator int() const { return value_; }
|
|
|
|
private:
|
|
int value_;
|
|
};
|
|
|
|
const uint8_t kNativeYieldFlags = 0x2;
|
|
|
|
enum LogicalOperator { kAnd, kOr };
|
|
|
|
class Program {
|
|
public:
|
|
// Read a kernel Program from the given Reader. Note the returned Program
|
|
// can potentially contain several "sub programs", though the library count
|
|
// etc will reference the last "sub program" only.
|
|
static Program* ReadFrom(Reader* reader, const char** error = nullptr);
|
|
|
|
static Program* ReadFromFile(const char* script_uri,
|
|
const char** error = nullptr);
|
|
static Program* ReadFromTypedData(const ExternalTypedData& typed_data,
|
|
const char** error = nullptr);
|
|
|
|
bool is_single_program() { return single_program_; }
|
|
uint32_t binary_version() { return binary_version_; }
|
|
NameIndex main_method() { return main_method_reference_; }
|
|
intptr_t source_table_offset() const { return source_table_offset_; }
|
|
intptr_t string_table_offset() const { return string_table_offset_; }
|
|
intptr_t name_table_offset() const { return name_table_offset_; }
|
|
intptr_t metadata_payloads_offset() const {
|
|
return metadata_payloads_offset_;
|
|
}
|
|
intptr_t metadata_mappings_offset() const {
|
|
return metadata_mappings_offset_;
|
|
}
|
|
intptr_t constant_table_offset() { return constant_table_offset_; }
|
|
intptr_t library_count() { return library_count_; }
|
|
|
|
const TypedDataBase& kernel_data() const { return *kernel_data_; }
|
|
|
|
private:
|
|
Program() : kernel_data_(NULL) {}
|
|
|
|
bool single_program_;
|
|
uint32_t binary_version_;
|
|
NameIndex main_method_reference_; // Procedure.
|
|
intptr_t library_count_;
|
|
|
|
// The offset from the start of the binary to the start of the source table.
|
|
intptr_t source_table_offset_;
|
|
|
|
// The offset from the start of the binary to the start of the constant table.
|
|
intptr_t constant_table_offset_;
|
|
|
|
// The offset from the start of the binary to the canonical name table.
|
|
intptr_t name_table_offset_;
|
|
|
|
// The offset from the start of the binary to the metadata payloads.
|
|
intptr_t metadata_payloads_offset_;
|
|
|
|
// The offset from the start of the binary to the metadata mappings.
|
|
intptr_t metadata_mappings_offset_;
|
|
|
|
// The offset from the start of the binary to the start of the string table.
|
|
intptr_t string_table_offset_;
|
|
|
|
// The kernel buffer for this program.
|
|
const TypedDataBase* kernel_data_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(Program);
|
|
};
|
|
|
|
class KernelLineStartsReader {
|
|
public:
|
|
KernelLineStartsReader(const dart::TypedData& line_starts_data,
|
|
dart::Zone* zone);
|
|
|
|
~KernelLineStartsReader() { delete helper_; }
|
|
|
|
int32_t DeltaAt(intptr_t index) const {
|
|
return helper_->At(line_starts_data_, index);
|
|
}
|
|
|
|
intptr_t LineNumberForPosition(intptr_t position) const;
|
|
|
|
void LocationForPosition(intptr_t position,
|
|
intptr_t* line,
|
|
intptr_t* col) const;
|
|
|
|
void TokenRangeAtLine(intptr_t source_length,
|
|
intptr_t line_number,
|
|
dart::TokenPosition* first_token_index,
|
|
dart::TokenPosition* last_token_index) const;
|
|
|
|
private:
|
|
class KernelLineStartsHelper {
|
|
public:
|
|
KernelLineStartsHelper() {}
|
|
virtual ~KernelLineStartsHelper() {}
|
|
virtual int32_t At(const dart::TypedData& data, intptr_t index) const = 0;
|
|
|
|
private:
|
|
DISALLOW_COPY_AND_ASSIGN(KernelLineStartsHelper);
|
|
};
|
|
|
|
class KernelInt8LineStartsHelper : public KernelLineStartsHelper {
|
|
public:
|
|
KernelInt8LineStartsHelper() {}
|
|
virtual int32_t At(const dart::TypedData& data, intptr_t index) const;
|
|
|
|
private:
|
|
DISALLOW_COPY_AND_ASSIGN(KernelInt8LineStartsHelper);
|
|
};
|
|
|
|
class KernelInt16LineStartsHelper : public KernelLineStartsHelper {
|
|
public:
|
|
KernelInt16LineStartsHelper() {}
|
|
virtual int32_t At(const dart::TypedData& data, intptr_t index) const;
|
|
|
|
private:
|
|
DISALLOW_COPY_AND_ASSIGN(KernelInt16LineStartsHelper);
|
|
};
|
|
|
|
class KernelInt32LineStartsHelper : public KernelLineStartsHelper {
|
|
public:
|
|
KernelInt32LineStartsHelper() {}
|
|
virtual int32_t At(const dart::TypedData& data, intptr_t index) const;
|
|
|
|
private:
|
|
DISALLOW_COPY_AND_ASSIGN(KernelInt32LineStartsHelper);
|
|
};
|
|
|
|
const dart::TypedData& line_starts_data_;
|
|
KernelLineStartsHelper* helper_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(KernelLineStartsReader);
|
|
};
|
|
|
|
bool FieldHasFunctionLiteralInitializer(const Field& field,
|
|
TokenPosition* start,
|
|
TokenPosition* end);
|
|
|
|
void CollectTokenPositionsFor(const Script& script);
|
|
|
|
RawObject* EvaluateMetadata(const Field& metadata_field,
|
|
bool is_annotations_offset);
|
|
RawObject* BuildParameterDescriptor(const Function& function);
|
|
|
|
// Fills in [is_covariant] and [is_generic_covariant_impl] vectors
|
|
// according to covariance attributes of [function] parameters.
|
|
//
|
|
// [is_covariant] and [is_generic_covariant_impl] should contain bitvectors
|
|
// of function.NumParameters() length.
|
|
void ReadParameterCovariance(const Function& function,
|
|
BitVector* is_covariant,
|
|
BitVector* is_generic_covariant_impl);
|
|
|
|
// Returns true if the given function needs dynamic invocation forwarder:
|
|
// that is if any of the arguments require checking on the dynamic
|
|
// call-site: if function has no parameters or has only covariant parameters
|
|
// as such function already checks all of its parameters.
|
|
bool NeedsDynamicInvocationForwarder(const Function& function);
|
|
|
|
ProcedureAttributesMetadata ProcedureAttributesOf(const Function& function,
|
|
Zone* zone);
|
|
|
|
ProcedureAttributesMetadata ProcedureAttributesOf(const Field& field,
|
|
Zone* zone);
|
|
|
|
} // namespace kernel
|
|
} // namespace dart
|
|
|
|
#endif // !defined(DART_PRECOMPILED_RUNTIME)
|
|
#endif // RUNTIME_VM_KERNEL_H_
|