Tess Strickland
c45c07592a
Disassembling on every run makes it difficult to get an idea of which specific configuration failed. Instead, just pick a configuration that already succeeded and test that configuration with disassembly separately so that it's clear if the disassembly was what caused the failure. Also add reasons to Expect.isTrue/isFalse uses in package:vm/v8_snapshot_profile.dart. Now we don't have to track down the specific line to find out what failed when reading logs. Another benefit is that the error message now includes the values involved in the failure and not just "Expect.isTrue(false)" or "Expect.isFalse(true)". Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-release-simarm_x64-try Change-Id: I3d4b533f4df041dfcced4eaeb8bc5729dfad0b82 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151502 Reviewed-by: Daco Harkes <dacoharkes@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>
This package hosts VM specific Dart code and helper scripts.