Martin Kustermann
b1df65ded8
This reduces e mail module by -4% in compressed form. It does have a increase of 2.5% in uncompressed form. This is due to repeated entries in the element section of the dynamic dispatch table and will be addressed in future CLs. Currently if the main module of an app has a dynamic call, it will have a caller-shape specific dynamic dispatcher that checks (via class ids) all possible targets in the app and issues calls to them. That means the code size is O(targets) - even if most targets reside in deferred modules. We change this now to use a row displacement table based dispatch, just as our normal typed dispatch table. Though there's a few differences * In a typed call we know the target exists, in a dynamic call we don't know whether the target exists (it may be a NSM case). To accomodate for this we make 2 wasm tables of the same layout: First we load a table of i31refs and check if the value is in agreement with the receiver class id. If so we have a match and can load the actual destination from the funcref table. * In typed calls we use one row in the table for each selector. In the dynamic invocation case we'll use one row per dynamic selector + call shape. * The wasm module that contains the actual instance method will also hold all it's dynamic forwarder functions (one per dynamic caller shape). The elements section of that module will cause initialization of the two slots in the two tables mentioned above. Issue https://github.com/dart-lang/sdk/issues/62639 Change-Id: I4e631f98fe9c58e2110bac34c3f5ff6d11bef909 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487660 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.