Tess Strickland
b1b3e34b88
Dart VM changes: Note that the following changes are backwards compatible in the case that a Dart program has no deferred loading units (i.e., the Dart program is contained in a single shared object snapshot). When there are non-root loading units, the non-symbol stack trace header now includes information about loading units as follows: loading_unit: N, build_id: S, dso_base: A, instructions: A where N is an integer, S is a string of hex digits (0-9a-f), and A is a word-sized address printed as a hex string (without prefix). In addition, all non-symbolic stack frames for isolate instructions include a unit field, including those for the root loading unit, e.g., #NN abs <address> unit <id> virt <address> <symbol>+<offset> If there are no non-root loading units, then the non-symbolic stack trace is unchanged from its previous format. Adds a build ID to split deferred loading unit snapshots. Fixes: https://github.com/dart-lang/sdk/issues/43516 If separate debugging information is requested, the loading unit manifest includes a 'debugPath' field for each loading unit, which contains the path to its separate debugging information. Removes the attempt to store the relocated address of the instructions section when running from an assembled snapshot in the initialized BSS. Adds OS::GetAppDSOBase, which takes a pointer to the instructions section and returns a pointer to its loaded shared object in memory. For compiled-to-ELF snapshots, it does this using the relocated address of the instructions in the Image, and for assembled snapshots, it delegates to NativeSymbolResolver::LookupSharedObject. ----- Changes to package:native_stack_traces: PCOffset now has two new fields: * int? unitId: the unit ID of the loading unit, when available. * String? buildId: the build ID of the loading unit, when available. For PCOffsets in the VM section, the unitId and buildId are those of the root loading unit. The constructor for the DwarfStackTraceDecoder now takes two additional optional named arguments: * Map<int, Dwarf>? dwarfByUnitId: A map associating loading unit IDs with the appropriate Dwarf object. May or may not contain an entry for the root loading unit. * Iterable<Dwarf>? unitDwarfs: An iterable container holding Dwarf objects. May or may not contain an entry for the root loading unit. The Dwarf object that is passed to the DwarfStackTraceDecoder as a positional argument is used for all lookups within the root loading unit. If the dwarfByUnitId or unitDwarfs arguments contain an entry for the root loading unit, it should be the same as the positional argument. When decoding a non-symbolic stack frame with a non-root loading unit id, the decoder first looks in the map for the appropriate Dwarf object. If one is not found, the decoder uses the build ID for the loading unit to find the appropriate Dwarf object in the iterable container. If an appropriate Dwarf object cannot be found in either manner, the non-symbolic stack frame is emitted without change. The native_stack_traces:decode executable now takes two additional multi-options for the translate command: * -u, --unit_debug: Takes a path to the associated DWARF information. * --unit_id_debug: Takes N=FILE, where N is the loading unit ID and FILE is a path to the associated DWARF information. The arguments to -u are collected into an iterable container to be passed as the unitDwarfs argument to the DwarfStackTraceDecoder, and the arguments to --unit-id-debug are collected into a map to be passed as the dwarfByUnitId argument. TEST=vm/dart/use_dwarf_stack_traces_flag_deferred Issue: https://github.com/dart-lang/sdk/issues/53902 Change-Id: I210d4f69e4ae9fd37275a96beb1aac55c5e9d080 Cq-Include-Trybots: luci.dart.try:vm-aot-dwarf-linux-product-x64-try,vm-aot-linux-release-x64-try,vm-aot-linux-debug-x64-try,vm-aot-mac-release-arm64-try,vm-aot-mac-product-arm64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362380 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency