Ömer Ağacan
f242e0f6c4
The update script at
`third_party/perfetto/tools/compile_perfetto_protos.dart` doesn't work
out of the box. Steps to to generate this CL:
- Apply diffs:
```
diff --git a/DEPS b/DEPS
index c7b224d28c2..6532cf91e8c 100644
--- a/DEPS
+++ b/DEPS
@@ -75,7 +75,7 @@ vars = {
"jsc_tag": "version:301576",
# https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang
- "clang_version": "git_revision:8b93f27cf7e6e53636db870873b53269efa3cca4",
+ "clang_version": "git_revision:49f39b349db181ca516eb0253462105ff0e2c634",
# https://chrome-infra-packages.appspot.com/p/gn/gn
"gn_version": "git_revision:07d3c6f4dc290fae5ca6152ebcb37d6815c411ab",
```
```
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index b041a075b5e..077dd104d79 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -651,6 +651,7 @@ if (is_win) {
"-Wno-tautological-constant-compare",
"-Wno-unused-but-set-variable", # icu
"-Wno-deprecated-non-prototype", # zlib
+ "-Wno-unnecessary-virtual-specifier",
]
} else {
default_warning_flags += [
```
This will make the perfetto build targets buildable.
- Remove all generated proto files in `pkg/vm_service_protos`.
`compile_perfetto_protos.dart` doesn't properly update existing files,
and doesn't delete files that are not generated by the protoc plugin.
- Run `third_party/perfetto/tools/compile_perfetto_protos.dart` with the
in-tree SDK.
- `git cl format .` to format generated files.
Also update transformer test expectations based on the new plugin and
the lib.
Tested: existing tests
Change-Id: I475f12313687b93b8f0ed01206cc7a9fcb2725e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459421
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
This package hosts VM specific Dart code and helper scripts.