Jens Johansen
ad596359a6
Before this CL the FFI transformation was always run (for target VM), so if for instance running dart2js (from source), e.g. like `out/ReleaseX64/dart -DDFE_VERBOSE=true pkg/compiler/bin/dart2js.dart --help` one could see how it spends something like 120-140 ms, which is something along the lines of 2.5% of the entire request processing (i.e. compile and serialization). This CL first checks if dart:ffi is imported at all. If it's not the transformation is skipped. When compiling dart2js (where, at least currently, dart:ffi is not used) this skips the transformation, thus saving the 120-140 ms (or ~2.5%). All measurements on my machine. Your mileage may vary. TEST=Existing tests. Change-Id: Ia5d3d7b989f549ca5da257660c204e8c59f15d4b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185543 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency