Srujan Gaddam
32565d1bcd
This reverts commit817306a735. Reason for revert: Later patchset includes fix for `frontend_server_circular_evaluate_test`. The fix is to cache the bundle/program compiler for all the libraries in the strongly connected component, and not just for the initial one that determines the component uri. Original change's description: > Revert "[frontend_server] Soft-deprecate moduleName for compileExpressionToJS" > > This reverts commit294a50fc6f. > > Reason for revert: This breaks `frontend_server_circular_evaluate_test` in DWDS. > > Original change's description: > > [frontend_server] Soft-deprecate moduleName for compileExpressionToJS > > > > https://github.com/dart-lang/sdk/issues/58265 > > > > The DDC library bundle format does not give names to modules. > > Therefore the frontend server should try and find the compiler > > associated with the library and not the module to be consistent. > > This then means that moduleName becomes entirely unused, and > > therefore we can soft-deprecate it. > > > > Change-Id: I241c63a346d046405599384409a373ab12be2654 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396102 > > Commit-Queue: Srujan Gaddam <srujzs@google.com> > > Reviewed-by: Johnni Winther <johnniwinther@google.com> > > Change-Id: I74b096f7ebc322c9d4428d236ab226ef1adcb6b9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396567 > Reviewed-by: Nicholas Shahan <nshahan@google.com> > Reviewed-by: Johnni Winther <johnniwinther@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Srujan Gaddam <srujzs@google.com> Change-Id: I45852c29a0b5735976f6a5f649f3ee84b26ef76c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396572 Reviewed-by: Nicholas Shahan <nshahan@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Srujan Gaddam <srujzs@google.com>
The frontend_server package is used by both the flutter command line tool and the frontend_server_client package (used by webdev and package:test).
API Stability
Changes to the command line API or behavior should be tested against the following test suites (in addition to normal HHH testing):
- flutter_tools: https://github.com/flutter/flutter/tree/master/packages/flutter_tools
- frontend_server_client: https://github.com/dart-lang/webdev/tree/master/frontend_server_client
Otherwise these changes will need to be carefully coordinated with the flutter tooling and frontend_server_client teams.
This API stability does not cover any of the source code APIs.
Stable subset
- The frontend_server kernel compilation and expression evaluation for kernel should be considered "stable".
- The frontend_server JavaScript compilation is semi-stable, but clients should anticipate coordinated breaking changes in the future.
- The frontend_server JavaScript expression evaluation is experimental and is expected to change significantly from Dec 2020 through the end of 2021.
- Specific flags may be added for experimentation and should not be considered stable.