Files
sdk/runtime/tests/vm
Alexander Aprelev 2472741ba0 [vm] Fix instance hash calculation to accommodate unboxed fields during cross compilation.
Instance hash calculation on host and on target should produce same
results(like when you use simarm_x64/gen_snapshot to produce arm snapshot).
It was not producing same results because of how unboxed fields could be
taking more than one word(on 32-bit arm they are taking two words).
Hash calculation was done in terms of words so simarm_x64/gen_snapshot
saw one word unboxed field, but same calculation saw two words.

The fix is to pay special attention when iterating over unboxed field
during hash calculation and accommodate host and target word size
difference.

Fixes https://github.com/dart-lang/sdk/issues/41824.

Change-Id: Ib280736fa458a3954ca1f9994734ad04ee8db80a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148040
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-05-15 01:28:55 +00:00
..