a75e9cd3ee
This reverts commit 08c13f173c.
Reason for revert: Causing failures on simarm, simarm64, etc
Original change's description:
> [pkg/native_stack_traces] Support Mach-O dSYM debugging information.
>
> TEST=vm/dart{,_2}/use_dwarf_stack_traces_flag
>
> Bug: https://github.com/dart-lang/sdk/issues/43612
> Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-mac-product-x64-try,pkg-mac-release-arm64-try,vm-kernel-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try
> Change-Id: Icda21bb14dcc0cf4784cea118e6ba7dd4edd35aa
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250381
> Commit-Queue: Tess Strickland <sstrickl@google.com>
> Reviewed-by: Slava Egorov <vegorov@google.com>
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: https://github.com/dart-lang/sdk/issues/43612
Change-Id: I020c29f7329e9b53a8fe0f4f4a4de4070fca0ec3
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-mac-product-x64-try,pkg-mac-release-arm64-try,vm-kernel-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251242
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
218 lines
8.5 KiB
Dart
218 lines
8.5 KiB
Dart
// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
import 'dart:math';
|
|
|
|
import 'constants.dart' as constants;
|
|
import 'dwarf.dart';
|
|
|
|
String _stackTracePiece(CallInfo call, int depth) =>
|
|
'#${depth.toString().padRight(6)} $call';
|
|
|
|
// A pattern matching the last line of the non-symbolic stack trace header.
|
|
//
|
|
// Currently, this happens to include the only pieces of information from the
|
|
// stack trace header we need: the absolute addresses during program
|
|
// execution of the start of the isolate and VM instructions.
|
|
//
|
|
// This RegExp has been adjusted to parse the header line found in
|
|
// non-symbolic stack traces and the modified version in signal handler stack
|
|
// traces.
|
|
final _headerEndRE = RegExp(r'isolate_instructions(?:=|: )([\da-f]+),? '
|
|
r'vm_instructions(?:=|: )([\da-f]+)');
|
|
|
|
// Parses instructions section information into a new [StackTraceHeader].
|
|
//
|
|
// Returns a new [StackTraceHeader] if [line] contains the needed header
|
|
// information, otherwise returns `null`.
|
|
StackTraceHeader? _parseInstructionsLine(String line) {
|
|
final match = _headerEndRE.firstMatch(line);
|
|
if (match == null) return null;
|
|
final isolateAddr = int.parse(match[1]!, radix: 16);
|
|
final vmAddr = int.parse(match[2]!, radix: 16);
|
|
return StackTraceHeader(isolateAddr, vmAddr);
|
|
}
|
|
|
|
/// Header information for a non-symbolic Dart stack trace.
|
|
class StackTraceHeader {
|
|
final int _isolateStart;
|
|
final int _vmStart;
|
|
|
|
StackTraceHeader(this._isolateStart, this._vmStart);
|
|
|
|
/// The [PCOffset] for the given absolute program counter address.
|
|
PCOffset offsetOf(int address) {
|
|
final isolateOffset = address - _isolateStart;
|
|
var vmOffset = address - _vmStart;
|
|
if (vmOffset > 0 && vmOffset == min(vmOffset, isolateOffset)) {
|
|
return PCOffset(vmOffset, InstructionsSection.vm);
|
|
} else {
|
|
return PCOffset(isolateOffset, InstructionsSection.isolate);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// A Dart DWARF stack trace contains up to four pieces of information:
|
|
/// - The zero-based frame index from the top of the stack.
|
|
/// - The absolute address of the program counter.
|
|
/// - The virtual address of the program counter, if the snapshot was
|
|
/// loaded as a dynamic library, otherwise not present.
|
|
/// - The location of the virtual address, which is one of the following:
|
|
/// - A dynamic symbol name, a plus sign, and an integer offset.
|
|
/// - The path to the snapshot, if it was loaded as a dynamic library,
|
|
/// otherwise the string "<unknown>".
|
|
const _symbolOffsetREString = r'(?<symbol>' +
|
|
constants.vmSymbolName +
|
|
r'|' +
|
|
constants.isolateSymbolName +
|
|
r')\+(?<offset>(?:0x)?[\da-f]+)';
|
|
final _symbolOffsetRE = RegExp(_symbolOffsetREString);
|
|
final _traceLineRE = RegExp(
|
|
r' #(\d+) abs (?<absolute>[\da-f]+)(?: virt (?<virtual>[\da-f]+))? '
|
|
r'(?<rest>.*)$');
|
|
|
|
/// Parses strings of the format <static symbol>+<integer offset>, where
|
|
/// <static symbol> is one of the static symbols used for Dart instruction
|
|
/// sections.
|
|
///
|
|
/// Unless forceHexadecimal is true, an integer offset without a "0x" prefix or
|
|
/// any hexdecimal digits will be parsed as decimal.
|
|
///
|
|
/// Returns null if the string is not of the expected format.
|
|
PCOffset? tryParseSymbolOffset(String s, [bool forceHexadecimal = false]) {
|
|
final match = _symbolOffsetRE.firstMatch(s);
|
|
if (match == null) return null;
|
|
final symbolString = match.namedGroup('symbol')!;
|
|
final offsetString = match.namedGroup('offset')!;
|
|
int? offset;
|
|
if (!forceHexadecimal && !offsetString.startsWith('0x')) {
|
|
offset = int.tryParse(offsetString);
|
|
}
|
|
if (offset == null) {
|
|
final digits = offsetString.startsWith('0x')
|
|
? offsetString.substring(2)
|
|
: offsetString;
|
|
offset = int.tryParse(digits, radix: 16);
|
|
}
|
|
if (offset == null) return null;
|
|
switch (symbolString) {
|
|
case constants.vmSymbolName:
|
|
return PCOffset(offset, InstructionsSection.vm);
|
|
case constants.isolateSymbolName:
|
|
return PCOffset(offset, InstructionsSection.isolate);
|
|
default:
|
|
break;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
PCOffset? _retrievePCOffset(StackTraceHeader? header, RegExpMatch? match) {
|
|
if (match == null) return null;
|
|
final restString = match.namedGroup('rest')!;
|
|
// Try checking for symbol information first, since we don't need the header
|
|
// information to translate it.
|
|
if (restString.isNotEmpty) {
|
|
final offset = tryParseSymbolOffset(restString);
|
|
if (offset != null) return offset;
|
|
}
|
|
// If we're parsing the absolute address, we can only convert it into
|
|
// a PCOffset if we saw the instructions line of the stack trace header.
|
|
if (header != null) {
|
|
final addressString = match.namedGroup('absolute')!;
|
|
final address = int.parse(addressString, radix: 16);
|
|
return header.offsetOf(address);
|
|
}
|
|
// If all other cases failed, check for a virtual address. Until this package
|
|
// depends on a version of Dart which only prints virtual addresses when the
|
|
// virtual addresses in the snapshot are the same as in separately saved
|
|
// debugging information, the other methods should be tried first.
|
|
final virtualString = match.namedGroup('virtual');
|
|
if (virtualString != null) {
|
|
final address = int.parse(virtualString, radix: 16);
|
|
return PCOffset(address, InstructionsSection.none);
|
|
}
|
|
return null;
|
|
}
|
|
|
|
/// The [PCOffset]s for frames of the non-symbolic stack traces in [lines].
|
|
Iterable<PCOffset> collectPCOffsets(Iterable<String> lines) sync* {
|
|
StackTraceHeader? header;
|
|
for (var line in lines) {
|
|
final parsedHeader = _parseInstructionsLine(line);
|
|
if (parsedHeader != null) {
|
|
header = parsedHeader;
|
|
continue;
|
|
}
|
|
final match = _traceLineRE.firstMatch(line);
|
|
final offset = _retrievePCOffset(header, match);
|
|
if (offset != null) yield offset;
|
|
}
|
|
}
|
|
|
|
/// A [StreamTransformer] that scans lines for non-symbolic stack traces.
|
|
///
|
|
/// A [NativeStackTraceDecoder] scans a stream of lines for non-symbolic
|
|
/// stack traces containing only program counter address information. Such
|
|
/// stack traces are generated by the VM when executing a snapshot compiled
|
|
/// with `--dwarf-stack-traces`.
|
|
///
|
|
/// The transformer assumes that there may be text preceding the stack frames
|
|
/// on individual lines, like in log files, but that there is no trailing text.
|
|
/// For each stack frame found, the transformer attempts to locate a function
|
|
/// name, file name and line number using the provided DWARF information.
|
|
///
|
|
/// If no information is found, or the line is not a stack frame, then the line
|
|
/// will be unchanged in the output stream.
|
|
///
|
|
/// If the located information corresponds to Dart internals and
|
|
/// [includeInternalFrames] is false, then the output stream contains no
|
|
/// entries for the line.
|
|
///
|
|
/// Otherwise, the output stream contains one or more lines with symbolic stack
|
|
/// frames for the given non-symbolic stack frame line. Multiple symbolic stack
|
|
/// frame lines are generated when the PC address corresponds to inlined code.
|
|
/// In the output stream, each symbolic stack frame is prefixed by the non-stack
|
|
/// frame portion of the original line.
|
|
class DwarfStackTraceDecoder extends StreamTransformerBase<String, String> {
|
|
final Dwarf _dwarf;
|
|
final bool _includeInternalFrames;
|
|
|
|
DwarfStackTraceDecoder(this._dwarf, {bool includeInternalFrames = false})
|
|
: _includeInternalFrames = includeInternalFrames;
|
|
|
|
@override
|
|
Stream<String> bind(Stream<String> stream) async* {
|
|
var depth = 0;
|
|
StackTraceHeader? header;
|
|
await for (final line in stream) {
|
|
final parsedHeader = _parseInstructionsLine(line);
|
|
if (parsedHeader != null) {
|
|
header = parsedHeader;
|
|
depth = 0;
|
|
yield line;
|
|
continue;
|
|
}
|
|
// If at any point we can't get appropriate information for the current
|
|
// line as a stack trace line, then just pass the line through unchanged.
|
|
final lineMatch = _traceLineRE.firstMatch(line);
|
|
final offset = _retrievePCOffset(header, lineMatch);
|
|
final callInfo = offset?.callInfoFrom(_dwarf,
|
|
includeInternalFrames: _includeInternalFrames);
|
|
if (callInfo == null) {
|
|
yield line;
|
|
continue;
|
|
}
|
|
// No lines to output (as this corresponds to Dart internals).
|
|
if (callInfo.isEmpty) continue;
|
|
// Output the lines for the symbolic frame with the prefix found on the
|
|
// original non-symbolic frame line.
|
|
final prefix = line.substring(0, lineMatch!.start);
|
|
for (final call in callInfo) {
|
|
yield prefix + _stackTracePiece(call, depth++);
|
|
}
|
|
}
|
|
}
|
|
}
|