Vyacheslav Egorov
f496e538f4
This is the next step towards preventing compiler from directly peeking into runtime and instead interact with runtime through a well defined surface. The goal of the refactoring to locate all places where compiler accesses some runtime information and partion those accesses into two categories: - creating objects in the host runtime (e.g. allocating strings, numbers, etc) during compilation; - accessing properties of the target runtime (e.g. offsets of fields) to embed those into the generated code; This change introduces dart::compiler and dart::compiler::target namespaces. All code in the compiler will gradually be moved into dart::compiler namespace. One of the motivations for this change is to be able to prevent access to globally defined host constants like kWordSize by shadowing them in the dart::compiler namespace. The nested namespace dart::compiler::target hosts all information about target runtime that compiler could access, e.g. compiler::target::kWordSize defines word size of the target which will eventually be made different from the host kWordSize (defined by dart::kWordSize). The API for compiler to runtime interaction is placed into compiler_api.h. Note that we still permit runtime to access compiler internals directly - this is not going to be decoupled as part of this work. Issue https://github.com/dart-lang/sdk/issues/31709 Change-Id: If4396d295879391becfa6c38d4802bbff81f5b20 Reviewed-on: https://dart-review.googlesource.com/c/90242 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
67 lines
2.6 KiB
C++
67 lines
2.6 KiB
C++
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/compiler/assembler/assembler.h"
|
|
#include "vm/globals.h"
|
|
#include "vm/os.h"
|
|
#include "vm/simulator.h"
|
|
#include "vm/unit_test.h"
|
|
#include "vm/virtual_memory.h"
|
|
|
|
namespace dart {
|
|
|
|
namespace compiler {
|
|
ASSEMBLER_TEST_EXTERN(StoreIntoObject);
|
|
} // namespace compiler
|
|
|
|
ASSEMBLER_TEST_RUN(StoreIntoObject, test) {
|
|
#define TEST_CODE(value, growable_array, thread) \
|
|
test->Invoke<void, RawObject*, RawObject*, Thread*>(value, growable_array, \
|
|
thread)
|
|
|
|
const Array& old_array = Array::Handle(Array::New(3, Heap::kOld));
|
|
const Array& new_array = Array::Handle(Array::New(3, Heap::kNew));
|
|
const GrowableObjectArray& grow_old_array = GrowableObjectArray::Handle(
|
|
GrowableObjectArray::New(old_array, Heap::kOld));
|
|
const GrowableObjectArray& grow_new_array = GrowableObjectArray::Handle(
|
|
GrowableObjectArray::New(old_array, Heap::kNew));
|
|
Smi& smi = Smi::Handle();
|
|
Thread* thread = Thread::Current();
|
|
|
|
EXPECT(old_array.raw() == grow_old_array.data());
|
|
EXPECT(!thread->StoreBufferContains(grow_old_array.raw()));
|
|
EXPECT(old_array.raw() == grow_new_array.data());
|
|
EXPECT(!thread->StoreBufferContains(grow_new_array.raw()));
|
|
|
|
// Store Smis into the old object.
|
|
for (int i = -128; i < 128; i++) {
|
|
smi = Smi::New(i);
|
|
TEST_CODE(smi.raw(), grow_old_array.raw(), thread);
|
|
EXPECT(reinterpret_cast<RawArray*>(smi.raw()) == grow_old_array.data());
|
|
EXPECT(!thread->StoreBufferContains(grow_old_array.raw()));
|
|
}
|
|
|
|
// Store an old object into the old object.
|
|
TEST_CODE(old_array.raw(), grow_old_array.raw(), thread);
|
|
EXPECT(old_array.raw() == grow_old_array.data());
|
|
EXPECT(!thread->StoreBufferContains(grow_old_array.raw()));
|
|
|
|
// Store a new object into the old object.
|
|
TEST_CODE(new_array.raw(), grow_old_array.raw(), thread);
|
|
EXPECT(new_array.raw() == grow_old_array.data());
|
|
EXPECT(thread->StoreBufferContains(grow_old_array.raw()));
|
|
|
|
// Store a new object into the new object.
|
|
TEST_CODE(new_array.raw(), grow_new_array.raw(), thread);
|
|
EXPECT(new_array.raw() == grow_new_array.data());
|
|
EXPECT(!thread->StoreBufferContains(grow_new_array.raw()));
|
|
|
|
// Store an old object into the new object.
|
|
TEST_CODE(old_array.raw(), grow_new_array.raw(), thread);
|
|
EXPECT(old_array.raw() == grow_new_array.data());
|
|
EXPECT(!thread->StoreBufferContains(grow_new_array.raw()));
|
|
}
|
|
|
|
} // namespace dart
|