Zach Anderson
0ccdc3ec38
This is a reland of https://dart-review.googlesource.com/c/sdk/+/62484 with the following changes: - _NativeSocket.connect now drops references to pending sockets on an error or successful connection. - eventhandlers are updated to ignore unset Dart ports on a close command. - Test updated to account for new SocketException. This is the second part of https://dart-review.googlesource.com/c/sdk/+/62484 This CL adds a startConnect method to Socket types that returns a ConnectionTask object that can be cancelled. Cancelling a ConnectionTask closes any sockets that were opened for the connection attempt that are not yet connected to the host. This allows a closing HttpClient to close sockets for pending requests whose sockets weren't fully connected yet. related https://github.com/flutter/flutter/issues/18617 Change-Id: I47fe3564e41197d622079aad4bb644bbdfe0bfe8 Reviewed-on: https://dart-review.googlesource.com/63040 Reviewed-by: Zach Anderson <zra@google.com> Commit-Queue: Zach Anderson <zra@google.com>
33 lines
911 B
Dart
33 lines
911 B
Dart
// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
//
|
|
// VMOptions=
|
|
// VMOptions=--short_socket_read
|
|
// VMOptions=--short_socket_write
|
|
// VMOptions=--short_socket_read --short_socket_write
|
|
|
|
import "dart:async";
|
|
import "dart:io";
|
|
|
|
import "package:async_helper/async_helper.dart";
|
|
import "package:expect/expect.dart";
|
|
|
|
void main() {
|
|
asyncStart();
|
|
Duration timeout = new Duration(milliseconds: 20);
|
|
Socket.startConnect("8.8.8.7", 80).then((task) {
|
|
task.socket.timeout(timeout, onTimeout: () {
|
|
task.cancel();
|
|
});
|
|
task.socket.then((socket) {
|
|
Expect.fail("Unexpected connection made.");
|
|
asyncEnd();
|
|
}).catchError((e) {
|
|
print(e);
|
|
Expect.isTrue(e is SocketException);
|
|
asyncEnd();
|
|
});
|
|
});
|
|
}
|