Aart Bik
a890d95a26
Rationale: Two closely related bugs found with fuzz testing! NaN must be preserved. We may improve comparisons on fp in the long run, but this CL avoids the incorrect optimization. Bug: https://github.com/dart-lang/sdk/issues/34467 https://github.com/dart-lang/sdk/issues/34466 Change-Id: Ie3667632eea2583098cf5f86a723ab4304d5d6c5 Reviewed-on: https://dart-review.googlesource.com/75242 Commit-Queue: Aart Bik <ajcbik@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
54 lines
1.3 KiB
Dart
54 lines
1.3 KiB
Dart
// Copyright (c) 2018, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
// Test NaN comparison (dartbug.com/34466 and dartbug.com/34467).
|
|
|
|
// VMOptions=--no_background_compilation --optimization_counter_threshold=10
|
|
|
|
import "package:expect/expect.dart";
|
|
|
|
double dvar = double.nan;
|
|
|
|
int doit() {
|
|
if (!(((-84).toDouble() <= double.nan))) {
|
|
return 1;
|
|
} else {
|
|
return 2;
|
|
}
|
|
}
|
|
|
|
doTests() {
|
|
Expect.isFalse(dvar > dvar);
|
|
Expect.isFalse(dvar < dvar);
|
|
Expect.isFalse(dvar <= dvar);
|
|
Expect.isFalse(dvar >= dvar);
|
|
Expect.isFalse(dvar > -dvar);
|
|
Expect.isFalse(-dvar > dvar);
|
|
|
|
Expect.isTrue(!(dvar > dvar));
|
|
Expect.isTrue(!(dvar < dvar));
|
|
Expect.isTrue(!(dvar <= dvar));
|
|
Expect.isTrue(!(dvar >= dvar));
|
|
Expect.isTrue(!(dvar > -dvar));
|
|
Expect.isTrue(!(-dvar > dvar));
|
|
|
|
Expect.equals(1, doit());
|
|
|
|
Expect.isFalse(dvar == dvar);
|
|
Expect.isFalse(dvar == -dvar);
|
|
Expect.isTrue(dvar != dvar);
|
|
Expect.isTrue(dvar != -dvar);
|
|
|
|
Expect.isTrue(!(dvar == dvar));
|
|
Expect.isTrue(!(dvar == -dvar));
|
|
Expect.isFalse(!(dvar != dvar));
|
|
Expect.isFalse(!(dvar != -dvar));
|
|
}
|
|
|
|
void main() {
|
|
for (int i = 0; i < 20; ++i) {
|
|
doTests();
|
|
}
|
|
}
|