Daco Harkes
77dc74bcd5
Closes: https://github.com/dart-lang/sdk/issues/38158 This CL implements unaligned access for float/double on arm32, but does not expose it in an API. Rather it only uses these loads/stores inside the getters and setters of packed structs. Bug: https://github.com/dart-lang/sdk/issues/45009 Besides unaligned access for float/double, this CL is mostly a CFE change. The only VM change is reading the packing in the `_FfiStructLayout` annotation. The implementation of using the packing in the VM, and analyzer changes have landed separately in earlier CLs. tools/test.py ffi ffi_2 TEST=tests/ffi(_2)/(.*)by_value_(*.)_test.dart Change-Id: Ic3106ecc626d2e30674a49bf03f65ae12d2b3502 Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try,dart-sdk-mac-try,dart-sdk-win-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-mac-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-win-release-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-msan-linux-release-x64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-precomp-android-release-arm_x64-try,analyzer-analysis-server-linux-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186143 Reviewed-by: Aske Simon Christensen <askesc@google.com>
95 lines
3.0 KiB
C++
95 lines
3.0 KiB
C++
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "vm/compiler/ffi/recognized_method.h"
|
|
|
|
#include "vm/symbols.h"
|
|
|
|
namespace dart {
|
|
|
|
namespace compiler {
|
|
|
|
namespace ffi {
|
|
|
|
classid_t ElementTypedDataCid(classid_t class_id) {
|
|
ASSERT(class_id >= kFfiPointerCid);
|
|
ASSERT(class_id < kFfiVoidCid);
|
|
ASSERT(class_id != kFfiNativeFunctionCid);
|
|
switch (class_id) {
|
|
case kFfiInt8Cid:
|
|
return kTypedDataInt8ArrayCid;
|
|
case kFfiUint8Cid:
|
|
return kTypedDataUint8ArrayCid;
|
|
case kFfiInt16Cid:
|
|
return kTypedDataInt16ArrayCid;
|
|
case kFfiUint16Cid:
|
|
return kTypedDataUint16ArrayCid;
|
|
case kFfiInt32Cid:
|
|
return kTypedDataInt32ArrayCid;
|
|
case kFfiUint32Cid:
|
|
return kTypedDataUint32ArrayCid;
|
|
case kFfiInt64Cid:
|
|
return kTypedDataInt64ArrayCid;
|
|
case kFfiUint64Cid:
|
|
return kTypedDataUint64ArrayCid;
|
|
case kFfiIntPtrCid:
|
|
return target::kWordSize == 4 ? kTypedDataInt32ArrayCid
|
|
: kTypedDataInt64ArrayCid;
|
|
case kFfiPointerCid:
|
|
return target::kWordSize == 4 ? kTypedDataUint32ArrayCid
|
|
: kTypedDataUint64ArrayCid;
|
|
case kFfiFloatCid:
|
|
return kTypedDataFloat32ArrayCid;
|
|
case kFfiDoubleCid:
|
|
return kTypedDataFloat64ArrayCid;
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
}
|
|
|
|
classid_t RecognizedMethodTypeArgCid(MethodRecognizer::Kind kind) {
|
|
switch (kind) {
|
|
#define LOAD_STORE(type) \
|
|
case MethodRecognizer::kFfiLoad##type: \
|
|
case MethodRecognizer::kFfiStore##type: \
|
|
return kFfi##type##Cid;
|
|
CLASS_LIST_FFI_NUMERIC(LOAD_STORE)
|
|
LOAD_STORE(Pointer)
|
|
#undef LOAD_STORE
|
|
case MethodRecognizer::kFfiLoadFloatUnaligned:
|
|
case MethodRecognizer::kFfiStoreFloatUnaligned:
|
|
return kFfiFloatCid;
|
|
case MethodRecognizer::kFfiLoadDoubleUnaligned:
|
|
case MethodRecognizer::kFfiStoreDoubleUnaligned:
|
|
return kFfiDoubleCid;
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
}
|
|
|
|
AlignmentType RecognizedMethodAlignment(MethodRecognizer::Kind kind) {
|
|
switch (kind) {
|
|
#define LOAD_STORE(type) \
|
|
case MethodRecognizer::kFfiLoad##type: \
|
|
case MethodRecognizer::kFfiStore##type: \
|
|
return kAlignedAccess;
|
|
CLASS_LIST_FFI_NUMERIC(LOAD_STORE)
|
|
LOAD_STORE(Pointer)
|
|
#undef LOAD_STORE
|
|
case MethodRecognizer::kFfiLoadFloatUnaligned:
|
|
case MethodRecognizer::kFfiStoreFloatUnaligned:
|
|
case MethodRecognizer::kFfiLoadDoubleUnaligned:
|
|
case MethodRecognizer::kFfiStoreDoubleUnaligned:
|
|
return kUnalignedAccess;
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
}
|
|
|
|
} // namespace ffi
|
|
|
|
} // namespace compiler
|
|
|
|
} // namespace dart
|