Daco Harkes
ffa5d16ae7
This CL only changes dart:ffi API, CFE, and analyzer. No VM changes were needed because the dimensions of inline arrays can be flattened before passing them to the VM. The multi-dimensionality does not impact the ABI. Closes: https://github.com/dart-lang/sdk/issues/45023 TEST=pkg/analyzer/test/src/diagnostics/size_annotation_dimensions_test.dart TEST=pkg/front_end/testcases/nnbd/ffi_struct_inline_array_multi_dimensional.dart TEST=tests/ffi/function_structs_by_value_generated_test.dart TEST=tests/ffi/inline_array_multi_dimensional_test.dart Change-Id: Ica2c01fccbea7e513879365b34086d8968b54c5b Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try,dart-sdk-mac-try,dart-sdk-win-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-mac-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-win-release-x64-try,vm-kernel-reload-linux-debug-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-msan-linux-release-x64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-precomp-android-release-arm_x64-try,analyzer-analysis-server-linux-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188286 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Aske Simon Christensen <askesc@google.com>
24 lines
1.2 KiB
Plaintext
24 lines
1.2 KiB
Plaintext
library /*isNonNullableByDefault*/;
|
|
import self as self;
|
|
import "dart:ffi" as ffi;
|
|
|
|
import "dart:ffi";
|
|
import "package:ffi/ffi.dart";
|
|
|
|
class StructInlineArray extends ffi::Struct {
|
|
synthetic constructor •() → self::StructInlineArray
|
|
;
|
|
@ffi::_ArraySize::•<ffi::NativeType>(8)
|
|
external get a0() → ffi::Array<ffi::Uint8>;
|
|
@ffi::_ArraySize::•<ffi::NativeType>(8)
|
|
external set a0(ffi::Array<ffi::Uint8> #externalFieldValue) → void;
|
|
}
|
|
static method main() → dynamic
|
|
;
|
|
|
|
|
|
Extra constant evaluation status:
|
|
Evaluated: ConstructorInvocation @ org-dartlang-testcase:///ffi_struct_inline_array.dart:10:4 -> InstanceConstant(const _ArraySize<NativeType*>{_ArraySize.dimension1: 8, _ArraySize.dimension2: null, _ArraySize.dimension3: null, _ArraySize.dimension4: null, _ArraySize.dimension5: null, _ArraySize.dimensions: null})
|
|
Evaluated: ConstructorInvocation @ org-dartlang-testcase:///ffi_struct_inline_array.dart:10:4 -> InstanceConstant(const _ArraySize<NativeType*>{_ArraySize.dimension1: 8, _ArraySize.dimension2: null, _ArraySize.dimension3: null, _ArraySize.dimension4: null, _ArraySize.dimension5: null, _ArraySize.dimensions: null})
|
|
Extra constant evaluation: evaluated: 2, effectively constant: 2
|