Alexander Markov
c1212311bf
Reland 1d6c1020c9 with the fix for ASAN
bots.
* Test standalone_2/file_error_test is updated for Dart 2.0 fixed-size
integers.
* This update revealed that certain dart:io native methods do not handle
out-of-memory properly when I/O buffers are allocated.
This CL fixes this bug.
* Updated test point is extracted to a separate test
standalone_2/file_error2_test as it needs custom ASAN options.
Change-Id: Ifb1fa59828f36dc03d45c18a41d45da6b989d70a
Reviewed-on: https://dart-review.googlesource.com/20908
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
35 lines
885 B
C++
35 lines
885 B
C++
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#include "bin/io_buffer.h"
|
|
|
|
namespace dart {
|
|
namespace bin {
|
|
|
|
Dart_Handle IOBuffer::Allocate(intptr_t size, uint8_t** buffer) {
|
|
uint8_t* data = Allocate(size);
|
|
if (data == NULL) {
|
|
return Dart_Null();
|
|
}
|
|
Dart_Handle result =
|
|
Dart_NewExternalTypedData(Dart_TypedData_kUint8, data, size);
|
|
Dart_NewWeakPersistentHandle(result, data, size, IOBuffer::Finalizer);
|
|
|
|
if (Dart_IsError(result)) {
|
|
Free(data);
|
|
Dart_PropagateError(result);
|
|
}
|
|
if (buffer != NULL) {
|
|
*buffer = data;
|
|
}
|
|
return result;
|
|
}
|
|
|
|
uint8_t* IOBuffer::Allocate(intptr_t size) {
|
|
return reinterpret_cast<uint8_t*>(malloc(size));
|
|
}
|
|
|
|
} // namespace bin
|
|
} // namespace dart
|