Paul Berry
aa00d4844e
In https://dart-review.googlesource.com/c/sdk/+/278649, I added assertions to flow analysis to make sure that `FlowAnalysis.declare` wasn't called more times than necessary. To work around a few instance in which it _was_ being called more than necessary, I added a parameter `skipDuplicateCheck` that caused the assertion to be skipped. This change fixes the one remaining case in which skipping the check was necessary, by moving the CFE logic that calls `FlowAnalysis.declare` for formal parameters. Previously, this logic was in both `BodyBuilder.finishFunction` and `BodyBuilder.finishConstructor`, resulting in some duplication because `BodyBuilder.finishFunction` sometimes calls `BodyBuilder.finishConstructor`. I've moved the logic into a new method, `BodyBuilder._declareFormals`, which is called from `BodyBuilder.finishFunction` and `BodyBuilder.parseInitializers`, ensuring that the calls to `FlowAnalysis.declare` only occur once. Fixing this case allows the `skipDuplicateCheck` hack to be removed entirely. Note that there was also one place where the analyzer was also using `skipDuplicateCheck`, but it was doing so unnecessarily. Change-Id: Ic34d1b7120f05d94c53774d52eb90e4ada67415f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434261 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Chloe Stefantsova <cstefantsova@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.