b464fc9037
This reverts commitcd2c566bcf. Reason for revert: Updating to not remove field used by Flutter engine. Original change's description: > Revert "Tweak `expect.dart` library." > > This reverts commitff5f391c0a. > > Reason for revert: The expect library is used by Flutter engine, and some of its tests use assertStatementsEnabled. There should be a migration path that doesn't require an atomic change, like adding the replacement api before removing the old one. > > Original change's description: > > Tweak `expect.dart` library. > > > > Make API more consistent for a few methods. > > Reduce the number of language features used in tests: > > * Never iterating an iterable, always converting it > > using `.toList()` first and iterating using indices > > (fx `setEquals`). > > Also require a `List` in places where an `Iterable` > > wasn't necessary. > > * Avoid doing complicated computations that are also > > used for the error message. Do simple check first, > > then recompute to get better error messages > > (fx `allDistinct`). > > > > Renamed some rarely used members for consistency > > (`stringContainsInOrder`->`containsInOrder`, > > where other string-contains functions just start > > with `contains`, and `containsOneOf` -> `containsAny` > > to match `Iterable.any` phrasing, and also it accepts > > if containing at least one, not precisely one.) > > > > Removed a function that wasn't used anywhere. > > > > Moved `assertStatementsEnabled` to `variations.dart` as `asserts`. > > Removed `typeAssertionsEnabled` and `checkedModeEnabled`. The former used in one place, where it was replaced with `checkedImplicitDowncasts` from `variations.dart`, the latter wasn't used anywhere. > > > > Deprecates `package:expect/minitest.dart`. It was never intended > > to be used for new tests, only as a help to convert existing tests > > written against `package:unit_test`. > > All existing imports marked as `// ignore: deprecated_member_use`. > > > > Change-Id: I07e21d4c0f3ccf11b82ee34af2668fdbb22264d2 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352360 > > Reviewed-by: Slava Egorov <vegorov@google.com> > > Reviewed-by: Ömer Ağacan <omersa@google.com> > > Reviewed-by: Nate Bosch <nbosch@google.com> > > Reviewed-by: Stephen Adams <sra@google.com> > > Commit-Queue: Lasse Nielsen <lrn@google.com> > > Change-Id: I360b4347470a0bb2b63c3108e2b83ee2a771bf3f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362020 > Reviewed-by: Nate Bosch <nbosch@google.com> > Reviewed-by: Ömer Ağacan <omersa@google.com> > Reviewed-by: Stephen Adams <sra@google.com> > Reviewed-by: Leaf Petersen <leafp@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: William Hesse <whesse@google.com> CoreLibraryReviewExempt: Reland Change-Id: I53db40edc0733842a008839c3913d51c885e39ab Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362502 Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Ömer Ağacan <omersa@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
102 lines
3.2 KiB
Dart
102 lines
3.2 KiB
Dart
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:html';
|
|
import 'dart:indexed_db' show IdbFactory, KeyRange;
|
|
import 'dart:typed_data' show Int32List;
|
|
import 'dart:js';
|
|
|
|
import 'package:js/js_util.dart' as js_util;
|
|
import 'package:expect/minitest.dart'; // ignore: deprecated_member_use_from_same_package
|
|
|
|
import 'js_test_util.dart';
|
|
|
|
main() {
|
|
injectJs();
|
|
|
|
test('hashCode and ==', () {
|
|
final o1 = context['Object'];
|
|
final o2 = context['Object'];
|
|
expect(o1 == o2, isTrue);
|
|
expect(o1.hashCode == o2.hashCode, isTrue);
|
|
final d = context['document'];
|
|
expect(o1 == d, isFalse);
|
|
});
|
|
|
|
test('toString', () {
|
|
var foo = new JsObject(context['Foo'], [42]);
|
|
expect(foo.toString(), equals("I'm a Foo a=42"));
|
|
var container = context['container'];
|
|
expect(container.toString(), equals("[object Object]"));
|
|
});
|
|
|
|
test('toString returns a String even if the JS object does not', () {
|
|
var foo = new JsObject(context['Liar']);
|
|
expect(foo.callMethod('toString'), 1);
|
|
expect(foo.toString(), '1');
|
|
});
|
|
|
|
test('instanceof', () {
|
|
var foo = new JsObject(context['Foo'], [1]);
|
|
expect(foo.instanceof(context['Foo']), isTrue);
|
|
expect(foo.instanceof(context['Object']), isTrue);
|
|
expect(foo.instanceof(context['String']), isFalse);
|
|
});
|
|
|
|
test('deleteProperty', () {
|
|
var object = new JsObject.jsify({});
|
|
object['a'] = 1;
|
|
expect(context['Object'].callMethod('keys', [object])['length'], 1);
|
|
expect(context['Object'].callMethod('keys', [object])[0], "a");
|
|
object.deleteProperty("a");
|
|
expect(context['Object'].callMethod('keys', [object])['length'], 0);
|
|
});
|
|
|
|
/* TODO(jacobr): this is another test that is inconsistent with JS semantics.
|
|
test('deleteProperty throws if name is not a String or num', () {
|
|
var object = new JsObject.jsify({});
|
|
expect(() => object.deleteProperty(true),
|
|
throwsArgumentError);
|
|
});
|
|
*/
|
|
|
|
test('hasProperty', () {
|
|
var object = new JsObject.jsify({});
|
|
object['a'] = 1;
|
|
expect(object.hasProperty('a'), isTrue);
|
|
expect(object.hasProperty('b'), isFalse);
|
|
});
|
|
|
|
/* TODO(jacobr): is this really the correct unchecked mode behavior?
|
|
test('hasProperty throws if name is not a String or num', () {
|
|
var object = new JsObject.jsify({});
|
|
expect(() => object.hasProperty(true),
|
|
throwsArgumentError);
|
|
});
|
|
*/
|
|
|
|
test('[] and []=', () {
|
|
final myArray = context['myArray'];
|
|
expect(myArray['length'], equals(1));
|
|
expect(myArray[0], equals("value1"));
|
|
myArray[0] = "value2";
|
|
expect(myArray['length'], equals(1));
|
|
expect(myArray[0], equals("value2"));
|
|
|
|
final foo = new JsObject(context['Foo'], [1]);
|
|
foo["getAge"] = () => 10;
|
|
expect(foo.callMethod('getAge'), equals(10));
|
|
});
|
|
|
|
/* TODO(jacobr): remove as we should only throw this in checked mode.
|
|
test('[] and []= throw if name is not a String or num', () {
|
|
var object = new JsObject.jsify({});
|
|
expect(() => object[true],
|
|
throwsArgumentError);
|
|
expect(() => object[true] = 1,
|
|
throwsArgumentError);
|
|
});
|
|
*/
|
|
}
|