Lasse R.H. Nielsen
b06a34fc5a
This never worked. It was silently accepted, at least if the future had no listeners, then any later attempt to use the future would cause a stack overflow or other impossible results. Moves some `_Future._complete` call out of try-catch. The `_complete` shouldn't throw (but before this fix it could). Moving them out of the `try`/`catch` makes such errors be reported as unhandled, instead of catching them and trying to complete the same future again with an error, when it's possibly in an inconsistent state. Fixes #43662. Based on https://github.com/dart-lang/sdk/issues/43662#issuecomment-2058870247 CoreLibraryReviewExempt: No response. Bug: http://dartbug.com/43662 Change-Id: I96a4f01bcd5b6cee93bba267299852569a9b905c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363060 Commit-Queue: Lasse Nielsen <lrn@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
96 lines
2.4 KiB
Dart
96 lines
2.4 KiB
Dart
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:async';
|
|
|
|
import 'package:async_helper/async_helper.dart';
|
|
import 'package:expect/expect.dart';
|
|
|
|
Future testOneScheduleMicrotask() {
|
|
var completer = new Completer();
|
|
Timer.run(() {
|
|
scheduleMicrotask(completer.complete);
|
|
});
|
|
return completer.future;
|
|
}
|
|
|
|
Future testMultipleScheduleMicrotask() {
|
|
var completer = new Completer();
|
|
Timer.run(() {
|
|
const TOTAL = 10;
|
|
int done = 0;
|
|
for (int i = 0; i < TOTAL; i++) {
|
|
scheduleMicrotask(() {
|
|
done++;
|
|
if (done == TOTAL) completer.complete();
|
|
;
|
|
});
|
|
}
|
|
});
|
|
return completer.future;
|
|
}
|
|
|
|
Future testScheduleMicrotaskThenTimer() {
|
|
var completer = new Completer();
|
|
Timer.run(() {
|
|
bool scheduleMicrotaskDone = false;
|
|
scheduleMicrotask(() {
|
|
Expect.isFalse(scheduleMicrotaskDone);
|
|
scheduleMicrotaskDone = true;
|
|
});
|
|
Timer.run(() {
|
|
Expect.isTrue(scheduleMicrotaskDone);
|
|
completer.complete();
|
|
});
|
|
});
|
|
return completer.future;
|
|
}
|
|
|
|
Future testTimerThenScheduleMicrotask() {
|
|
var completer = new Completer();
|
|
Timer.run(() {
|
|
bool scheduleMicrotaskDone = false;
|
|
Timer.run(() {
|
|
Expect.isTrue(scheduleMicrotaskDone);
|
|
completer.complete();
|
|
});
|
|
scheduleMicrotask(() {
|
|
Expect.isFalse(scheduleMicrotaskDone);
|
|
scheduleMicrotaskDone = true;
|
|
});
|
|
});
|
|
return completer.future;
|
|
}
|
|
|
|
Future testTimerThenScheduleMicrotaskChain() {
|
|
var completer = new Completer();
|
|
Timer.run(() {
|
|
const TOTAL = 10;
|
|
int scheduleMicrotaskDone = 0;
|
|
Timer.run(() {
|
|
Expect.equals(TOTAL, scheduleMicrotaskDone);
|
|
completer.complete();
|
|
});
|
|
void scheduleMicrotaskCallback() {
|
|
scheduleMicrotaskDone++;
|
|
if (scheduleMicrotaskDone != TOTAL) {
|
|
scheduleMicrotask(scheduleMicrotaskCallback);
|
|
}
|
|
}
|
|
|
|
scheduleMicrotask(scheduleMicrotaskCallback);
|
|
});
|
|
return completer.future;
|
|
}
|
|
|
|
main() {
|
|
asyncStart();
|
|
testOneScheduleMicrotask()
|
|
.then((_) => testMultipleScheduleMicrotask())
|
|
.then((_) => testScheduleMicrotaskThenTimer())
|
|
.then((_) => testTimerThenScheduleMicrotask())
|
|
.then((_) => testTimerThenScheduleMicrotaskChain())
|
|
.then((_) => asyncEnd());
|
|
}
|