Lasse R.H. Nielsen
b06a34fc5a
This never worked. It was silently accepted, at least if the future had no listeners, then any later attempt to use the future would cause a stack overflow or other impossible results. Moves some `_Future._complete` call out of try-catch. The `_complete` shouldn't throw (but before this fix it could). Moving them out of the `try`/`catch` makes such errors be reported as unhandled, instead of catching them and trying to complete the same future again with an error, when it's possibly in an inconsistent state. Fixes #43662. Based on https://github.com/dart-lang/sdk/issues/43662#issuecomment-2058870247 CoreLibraryReviewExempt: No response. Bug: http://dartbug.com/43662 Change-Id: I96a4f01bcd5b6cee93bba267299852569a9b905c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363060 Commit-Queue: Lasse Nielsen <lrn@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
61 lines
1.2 KiB
Dart
61 lines
1.2 KiB
Dart
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
library future_delayed_test;
|
|
|
|
import 'dart:async';
|
|
|
|
import 'package:async_helper/async_helper.dart';
|
|
import 'package:expect/expect.dart';
|
|
|
|
Future<int> createIntFuture() {
|
|
return new Future<int>.value(499);
|
|
}
|
|
|
|
unnamed() {
|
|
asyncStart();
|
|
new Future<int>(createIntFuture).then((x) {
|
|
Expect.equals(499, x);
|
|
asyncEnd();
|
|
});
|
|
}
|
|
|
|
delayed() {
|
|
asyncStart();
|
|
new Future<int>.delayed(const Duration(milliseconds: 2), createIntFuture)
|
|
.then((x) {
|
|
Expect.equals(499, x);
|
|
asyncEnd();
|
|
});
|
|
}
|
|
|
|
microtask() {
|
|
asyncStart();
|
|
new Future<int>.microtask(createIntFuture).then((x) {
|
|
Expect.equals(499, x);
|
|
asyncEnd();
|
|
});
|
|
}
|
|
|
|
sync() {
|
|
asyncStart();
|
|
new Future<int>.sync(createIntFuture).then((x) {
|
|
Expect.equals(499, x);
|
|
asyncEnd();
|
|
});
|
|
}
|
|
|
|
main() {
|
|
asyncStart();
|
|
// Test that all the Future constructors take functions that return a Future
|
|
// as argument.
|
|
// In particular the constructors must not type their argument as
|
|
// `T computation()`.
|
|
unnamed();
|
|
delayed();
|
|
microtask();
|
|
sync();
|
|
asyncEnd();
|
|
}
|