Vyacheslav Egorov
e2efffa005
This reland commit5a32d8bc7cwith a fix for thread leak (Issue #56717): when `ThreadPool` is shutting down asynchronously the last worker should detach itself to prevent leaking associated low-level data structures, because no thread will join it. A hang in service isolate shutdown (caused by an existing bug) was fixed by commit157a0dc7f9. This CL turns native ports into a thin abstraction over underlying thread pool instead of building them as full fledged MessageHandler. This allows to easily implement a variation of native ports which can handle messages concurrently with the given degree of concurrency. This type of port can be used to greatly simplify implementation of IOService - which previously had to do its own concurrency management on top of "single threaded" native ports. This capability is exposed as `Dart_NewConcurrentNativePort` API. The new implementation is in general much cleaner then the old one with one exception: `Dart_CloseNativePort` API has unfortunate design where underlying message handler is destroyed asynchronously and `Dart_CloseNativePort` returns immediately without waiting for pending tasks to complete. Implementing this on top of `ThreadPool` requires some changes to thread pool implementation. Issue https://github.com/dart-lang/sdk/issues/55844 Closes https://github.com/dart-lang/sdk/issues/56717 TEST=ci Change-Id: Ic68bfb60757685afd75c80a70cdec66cc13c149b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/385000 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Slava Egorov <vegorov@google.com>
77 lines
2.5 KiB
C++
77 lines
2.5 KiB
C++
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
#if defined(DART_IO_SECURE_SOCKET_DISABLED)
|
|
|
|
#include "bin/io_service_no_ssl.h"
|
|
|
|
#include "bin/dartutils.h"
|
|
#include "bin/directory.h"
|
|
#include "bin/file.h"
|
|
#include "bin/io_buffer.h"
|
|
#include "bin/socket.h"
|
|
#include "bin/utils.h"
|
|
|
|
#include "include/dart_api.h"
|
|
|
|
#include "platform/globals.h"
|
|
#include "platform/utils.h"
|
|
|
|
namespace dart {
|
|
namespace bin {
|
|
|
|
#define CASE_REQUEST(type, method, id) \
|
|
case IOService::k##type##method##Request: \
|
|
response = type::method##Request(data); \
|
|
break;
|
|
|
|
void IOServiceCallback(Dart_Port dest_port_id, Dart_CObject* message) {
|
|
Dart_Port reply_port_id = ILLEGAL_PORT;
|
|
CObject* response = CObject::IllegalArgumentError();
|
|
CObjectArray request(message);
|
|
if ((message->type == Dart_CObject_kArray) && (request.Length() == 4) &&
|
|
request[0]->IsInt32() && request[1]->IsSendPort() &&
|
|
request[2]->IsInt32() && request[3]->IsArray()) {
|
|
CObjectInt32 message_id(request[0]);
|
|
CObjectSendPort reply_port(request[1]);
|
|
CObjectInt32 request_id(request[2]);
|
|
CObjectArray data(request[3]);
|
|
reply_port_id = reply_port.Value();
|
|
switch (request_id.Value()) {
|
|
IO_SERVICE_REQUEST_LIST(CASE_REQUEST);
|
|
default:
|
|
UNREACHABLE();
|
|
}
|
|
}
|
|
|
|
CObjectArray result(CObject::NewArray(2));
|
|
result.SetAt(0, request[0]);
|
|
result.SetAt(1, response);
|
|
ASSERT(reply_port_id != ILLEGAL_PORT);
|
|
Dart_PostCObject(reply_port_id, result.AsApiCObject());
|
|
}
|
|
|
|
Dart_Port IOService::GetServicePort() {
|
|
return Dart_NewConcurrentNativePort("IOService", IOServiceCallback,
|
|
/*max_concurrency=*/32);
|
|
}
|
|
|
|
void FUNCTION_NAME(IOService_NewServicePort)(Dart_NativeArguments args) {
|
|
Dart_Port service_port = IOService::GetServicePort();
|
|
if (service_port != ILLEGAL_PORT) {
|
|
// Return a send port for the service port.
|
|
Dart_Handle send_port = Dart_NewSendPort(service_port);
|
|
Dart_SetReturnValue(args, send_port);
|
|
} else {
|
|
// If port is not successfully created throw an error.
|
|
Dart_PropagateError(
|
|
DartUtils::NewInternalError("Unable to create native port"));
|
|
}
|
|
}
|
|
|
|
} // namespace bin
|
|
} // namespace dart
|
|
|
|
#endif // defined(DART_IO_SECURE_SOCKET_DISABLED)
|