Ben Konyi
2408d38878
Previously, if a test timed out and the `tearDown` callback was invoked to cleanup the temporary project, we would try and cleanup the temporary directory even if the subprocess hadn't exited. This works fine on most platforms, but causes an exception to be thrown on Windows as the subprocess still holds a handle to the temporary directory. Ensuring the subprocess is killed before deleting the temporary directory will prevent us from encountering errors on cleanup on Windows. Fixes https://github.com/dart-lang/sdk/issues/47700 Change-Id: I71599908c31a1b32afed15c1388d228618462506 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220641 Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
378 lines
12 KiB
Dart
378 lines
12 KiB
Dart
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'dart:convert';
|
|
import 'dart:io';
|
|
|
|
import 'package:dartdev/dartdev.dart';
|
|
import 'package:dartdev/src/analytics.dart';
|
|
import 'package:test/test.dart';
|
|
|
|
import 'experiment_util.dart';
|
|
import 'utils.dart';
|
|
|
|
List<Map> extractAnalytics(ProcessResult result) {
|
|
return LineSplitter.split(result.stderr)
|
|
.where((line) => line.startsWith('[analytics]: '))
|
|
.map((line) => json.decode(line.substring('[analytics]: '.length)) as Map)
|
|
.toList();
|
|
}
|
|
|
|
Future<void> main() async {
|
|
group('DisabledAnalytics', disabledAnalyticsObject);
|
|
|
|
group('VM -> CLI --analytics flag smoke test:', () {
|
|
final command = DartdevRunner(['--analytics']);
|
|
test('--analytics', () {
|
|
command.runCommand(command.parse(['--analytics']));
|
|
expect(command.analytics is! DisabledAnalytics, true);
|
|
});
|
|
|
|
test('--no-analytics', () {
|
|
command.runCommand(command.parse(['--no-analytics']));
|
|
expect(command.analytics is DisabledAnalytics, true);
|
|
});
|
|
|
|
test('No flag', () {
|
|
command.runCommand(command.parse([]));
|
|
expect(command.analytics is! DisabledAnalytics, true);
|
|
});
|
|
});
|
|
|
|
test('Analytics control smoke test', () async {
|
|
final p = project(logAnalytics: true);
|
|
var result = await p.run(['--disable-analytics']);
|
|
expect(result.stdout, contains('''
|
|
╔════════════════════════════════════════════════════════════════════════════╗
|
|
║ Analytics reporting disabled. In order to enable it, run: ║
|
|
║ ║
|
|
║ dart --enable-analytics ║
|
|
║ ║
|
|
╚════════════════════════════════════════════════════════════════════════════╝
|
|
'''));
|
|
|
|
result = await p.run(['--enable-analytics']);
|
|
expect(result.stdout, contains('''
|
|
╔════════════════════════════════════════════════════════════════════════════╗
|
|
║ The Dart tool uses Google Analytics to report feature usage statistics ║
|
|
║ and to send basic crash reports. This data is used to help improve the ║
|
|
║ Dart platform and tools over time. ║
|
|
║ ║
|
|
║ To disable reporting of analytics, run: ║
|
|
║ ║
|
|
║ dart --disable-analytics ║
|
|
║ ║
|
|
╚════════════════════════════════════════════════════════════════════════════╝
|
|
'''));
|
|
});
|
|
|
|
final experiments = await experimentsWithValidation();
|
|
group('Sending analytics', () {
|
|
test('help', () async {
|
|
final p = project(logAnalytics: true);
|
|
final result = await p.run(['help']);
|
|
expect(extractAnalytics(result), [
|
|
{
|
|
'hitType': 'screenView',
|
|
'message': {'viewName': 'help', 'sc': 'start'}
|
|
},
|
|
{
|
|
'hitType': 'event',
|
|
'message': {
|
|
'category': 'dartdev',
|
|
'action': 'help',
|
|
'label': null,
|
|
'value': null
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'timing',
|
|
'message': {
|
|
'variableName': 'help',
|
|
'time': isA<int>(),
|
|
'category': 'commands',
|
|
'label': null
|
|
}
|
|
}
|
|
]);
|
|
});
|
|
test('create', () async {
|
|
final p = project(logAnalytics: true);
|
|
final result =
|
|
await p.run(['create', '--no-pub', '-tpackage-simple', 'name']);
|
|
expect(extractAnalytics(result), [
|
|
{
|
|
'hitType': 'screenView',
|
|
'message': {'viewName': 'create', 'sc': 'start'}
|
|
},
|
|
{
|
|
'hitType': 'event',
|
|
'message': {
|
|
'category': 'dartdev',
|
|
'action': 'create',
|
|
'label': null,
|
|
'value': null,
|
|
'cd1': '0',
|
|
'cd3': ' pub template ',
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'timing',
|
|
'message': {
|
|
'variableName': 'create',
|
|
'time': isA<int>(),
|
|
'category': 'commands',
|
|
'label': null
|
|
}
|
|
}
|
|
]);
|
|
});
|
|
|
|
test('pub get dry run', () async {
|
|
final p = project(logAnalytics: true, pubspec: {
|
|
'name': 'foo',
|
|
'environment': {'sdk': '>=2.10.0 <3.0.0'},
|
|
'dependencies': {'_dummy_pkg': '0.0.1'}
|
|
});
|
|
final result = await p.run(['pub', 'get', '--dry-run']);
|
|
expect(extractAnalytics(result), [
|
|
{
|
|
'hitType': 'screenView',
|
|
'message': {'viewName': 'pub/get', 'sc': 'start'}
|
|
},
|
|
{
|
|
'hitType': 'event',
|
|
'message': {
|
|
'category': 'dartdev',
|
|
'action': 'pub/get',
|
|
'label': null,
|
|
'value': null,
|
|
'cd1': '0',
|
|
'cd3': ' dry-run '
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'timing',
|
|
'message': {
|
|
'variableName': 'pub/get',
|
|
'time': isA<int>(),
|
|
'category': 'commands',
|
|
'label': null
|
|
}
|
|
}
|
|
]);
|
|
});
|
|
|
|
test('pub get', () async {
|
|
final p = project(logAnalytics: true, pubspec: {
|
|
'name': 'foo',
|
|
'environment': {'sdk': '>=2.10.0 <3.0.0'},
|
|
'dependencies': {'_dummy_pkg': '0.0.1'}
|
|
});
|
|
final result = await p.run(['pub', 'get']);
|
|
expect(extractAnalytics(result), [
|
|
{
|
|
'hitType': 'screenView',
|
|
'message': {'viewName': 'pub/get', 'sc': 'start'},
|
|
},
|
|
{
|
|
'hitType': 'event',
|
|
'message': {
|
|
'category': 'pub-get',
|
|
'action': '_dummy_pkg',
|
|
'label': '0.0.1',
|
|
'value': 1,
|
|
'ni': '1',
|
|
'cd4': 'direct'
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'timing',
|
|
'message': {
|
|
'variableName': 'resolution',
|
|
'time': isA<int>(),
|
|
'category': 'pub-get',
|
|
'label': null
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'event',
|
|
'message': {
|
|
'category': 'dartdev',
|
|
'action': 'pub/get',
|
|
'label': null,
|
|
'value': null,
|
|
'cd1': '0',
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'timing',
|
|
'message': {
|
|
'variableName': 'pub/get',
|
|
'time': isA<int>(),
|
|
'category': 'commands',
|
|
'label': null
|
|
}
|
|
}
|
|
]);
|
|
});
|
|
|
|
test('format', () async {
|
|
final p = project(logAnalytics: true);
|
|
final result = await p.run(['format', '-l80', '.']);
|
|
expect(extractAnalytics(result), [
|
|
{
|
|
'hitType': 'screenView',
|
|
'message': {'viewName': 'format', 'sc': 'start'}
|
|
},
|
|
{
|
|
'hitType': 'event',
|
|
'message': {
|
|
'category': 'dartdev',
|
|
'action': 'format',
|
|
'label': null,
|
|
'value': null,
|
|
'cd1': '0',
|
|
'cd3': ' line-length ',
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'timing',
|
|
'message': {
|
|
'variableName': 'format',
|
|
'time': isA<int>(),
|
|
'category': 'commands',
|
|
'label': null
|
|
}
|
|
}
|
|
]);
|
|
});
|
|
|
|
test('run', () async {
|
|
final p = project(
|
|
mainSrc: 'void main(List<String> args) => print(args)',
|
|
logAnalytics: true);
|
|
final result = await p.run([
|
|
'run',
|
|
'--no-pause-isolates-on-exit',
|
|
'--enable-asserts',
|
|
'lib/main.dart',
|
|
'--argument'
|
|
]);
|
|
expect(extractAnalytics(result), [
|
|
{
|
|
'hitType': 'screenView',
|
|
'message': {'viewName': 'run', 'sc': 'start'},
|
|
},
|
|
{
|
|
'hitType': 'event',
|
|
'message': {
|
|
'category': 'dartdev',
|
|
'action': 'run',
|
|
'label': null,
|
|
'value': null,
|
|
'cd1': '0',
|
|
'cd3': ' enable-asserts pause-isolates-on-exit ',
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'timing',
|
|
'message': {
|
|
'variableName': 'run',
|
|
'time': isA<int>(),
|
|
'category': 'commands',
|
|
'label': null
|
|
}
|
|
}
|
|
]);
|
|
});
|
|
group('run --enable-experiments', () {
|
|
for (final experiment in experiments) {
|
|
test(experiment.name, () async {
|
|
final p = project(mainSrc: experiment.validation, logAnalytics: true);
|
|
{
|
|
for (final no in ['', 'no-']) {
|
|
final result = await p.run([
|
|
'run',
|
|
'--enable-experiment=$no${experiment.name}',
|
|
'lib/main.dart',
|
|
]);
|
|
expect(extractAnalytics(result), [
|
|
{
|
|
'hitType': 'screenView',
|
|
'message': {'viewName': 'run', 'sc': 'start'},
|
|
},
|
|
{
|
|
'hitType': 'event',
|
|
'message': {
|
|
'category': 'dartdev',
|
|
'action': 'run',
|
|
'label': null,
|
|
'value': null,
|
|
'cd1': '0',
|
|
'cd2': ' $no${experiment.name} ',
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'timing',
|
|
'message': {
|
|
'variableName': 'run',
|
|
'time': isA<int>(),
|
|
'category': 'commands',
|
|
'label': null
|
|
}
|
|
}
|
|
]);
|
|
}
|
|
}
|
|
});
|
|
}
|
|
});
|
|
|
|
test('compile', () async {
|
|
final p = project(
|
|
mainSrc: 'void main(List<String> args) => print(args);',
|
|
logAnalytics: true);
|
|
final result = await p
|
|
.run(['compile', 'kernel', 'lib/main.dart', '-o', 'main.kernel']);
|
|
expect(extractAnalytics(result), [
|
|
{
|
|
'hitType': 'screenView',
|
|
'message': {'viewName': 'compile/kernel', 'sc': 'start'},
|
|
},
|
|
{
|
|
'hitType': 'event',
|
|
'message': {
|
|
'category': 'dartdev',
|
|
'action': 'compile/kernel',
|
|
'label': null,
|
|
'value': null,
|
|
'cd1': '0',
|
|
'cd3': ' output ',
|
|
}
|
|
},
|
|
{
|
|
'hitType': 'timing',
|
|
'message': {
|
|
'variableName': 'compile/kernel',
|
|
'time': isA<int>(),
|
|
'category': 'commands',
|
|
'label': null
|
|
}
|
|
}
|
|
]);
|
|
});
|
|
});
|
|
}
|
|
|
|
void disabledAnalyticsObject() {
|
|
test('object', () {
|
|
var diabledAnalytics = DisabledAnalytics('trackingId', 'appName');
|
|
expect(diabledAnalytics.trackingId, 'trackingId');
|
|
expect(diabledAnalytics.applicationName, 'appName');
|
|
expect(diabledAnalytics.enabled, isFalse);
|
|
expect(diabledAnalytics.firstRun, isFalse);
|
|
});
|
|
}
|