f8b1161496
The message for this error code doesn't accept any arguments, so there's no reason for the test to provide any. Change-Id: I6306cead7865704c9074dd0dc2a1bc1aacaeda16 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213724 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
174 lines
5.7 KiB
Dart
174 lines
5.7 KiB
Dart
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
import 'package:analyzer/dart/analysis/declared_variables.dart';
|
|
import 'package:analyzer/error/error.dart';
|
|
import 'package:analyzer/source/error_processor.dart';
|
|
import 'package:analyzer/src/analysis_options/analysis_options_provider.dart';
|
|
import 'package:analyzer/src/context/context.dart';
|
|
import 'package:analyzer/src/dart/analysis/session.dart';
|
|
import 'package:analyzer/src/error/codes.dart';
|
|
import 'package:analyzer/src/generated/engine.dart';
|
|
import 'package:analyzer/src/generated/source.dart';
|
|
import 'package:analyzer/src/task/options.dart';
|
|
import 'package:collection/collection.dart';
|
|
import 'package:test/test.dart';
|
|
import 'package:yaml/yaml.dart';
|
|
|
|
import '../generated/test_support.dart';
|
|
import '../src/util/yaml_test.dart';
|
|
|
|
main() {
|
|
AnalysisError invalid_assignment = AnalysisError(
|
|
TestSource(), 0, 1, CompileTimeErrorCode.INVALID_ASSIGNMENT, [
|
|
['x'],
|
|
['y']
|
|
]);
|
|
|
|
AnalysisError missing_return =
|
|
AnalysisError(TestSource(), 0, 1, HintCode.MISSING_RETURN, [
|
|
['x']
|
|
]);
|
|
|
|
AnalysisError unused_local_variable =
|
|
AnalysisError(TestSource(), 0, 1, HintCode.UNUSED_LOCAL_VARIABLE, [
|
|
['x']
|
|
]);
|
|
|
|
AnalysisError use_of_void_result = AnalysisError(
|
|
TestSource(), 0, 1, CompileTimeErrorCode.USE_OF_VOID_RESULT, []);
|
|
|
|
// We in-line a lint code here in order to avoid adding a dependency on the
|
|
// linter package.
|
|
AnalysisError annotate_overrides =
|
|
AnalysisError(TestSource(), 0, 1, LintCode('annotate_overrides', ''));
|
|
|
|
setUp(() {
|
|
context = TestContext();
|
|
});
|
|
|
|
group('ErrorProcessor', () {
|
|
test('configureOptions', () {
|
|
configureOptions('''
|
|
analyzer:
|
|
errors:
|
|
invalid_assignment: error # severity ERROR
|
|
missing_return: false # ignore
|
|
unused_local_variable: true # skipped
|
|
use_of_void_result: unsupported_action # skipped
|
|
''');
|
|
expect(getProcessor(invalid_assignment)!.severity, ErrorSeverity.ERROR);
|
|
expect(getProcessor(missing_return)!.severity, isNull);
|
|
expect(getProcessor(unused_local_variable), isNull);
|
|
expect(getProcessor(use_of_void_result), isNull);
|
|
});
|
|
|
|
test('does not upgrade other warnings to errors in strong mode', () {
|
|
configureOptions('''
|
|
analyzer:
|
|
strong-mode: true
|
|
''');
|
|
expect(getProcessor(unused_local_variable), isNull);
|
|
});
|
|
});
|
|
|
|
group('ErrorConfig', () {
|
|
var config = '''
|
|
analyzer:
|
|
errors:
|
|
invalid_assignment: unsupported_action # should be skipped
|
|
missing_return: false
|
|
unused_local_variable: error
|
|
''';
|
|
|
|
group('processing', () {
|
|
test('yaml map', () {
|
|
var options = optionsProvider.getOptionsFromString(config);
|
|
var errorConfig =
|
|
ErrorConfig((options['analyzer'] as YamlMap)['errors']);
|
|
expect(errorConfig.processors, hasLength(2));
|
|
|
|
// ignore
|
|
var missingReturnProcessor = errorConfig.processors
|
|
.firstWhere((p) => p.appliesTo(missing_return));
|
|
expect(missingReturnProcessor.severity, isNull);
|
|
|
|
// error
|
|
var unusedLocalProcessor = errorConfig.processors
|
|
.firstWhere((p) => p.appliesTo(unused_local_variable));
|
|
expect(unusedLocalProcessor.severity, ErrorSeverity.ERROR);
|
|
|
|
// skip
|
|
var invalidAssignmentProcessor = errorConfig.processors
|
|
.firstWhereOrNull((p) => p.appliesTo(invalid_assignment));
|
|
expect(invalidAssignmentProcessor, isNull);
|
|
});
|
|
|
|
test('string map', () {
|
|
var options = wrap({
|
|
'invalid_assignment': 'unsupported_action', // should be skipped
|
|
'missing_return': 'false',
|
|
'unused_local_variable': 'error'
|
|
});
|
|
var errorConfig = ErrorConfig(options);
|
|
expect(errorConfig.processors, hasLength(2));
|
|
|
|
// ignore
|
|
var missingReturnProcessor = errorConfig.processors
|
|
.firstWhere((p) => p.appliesTo(missing_return));
|
|
expect(missingReturnProcessor.severity, isNull);
|
|
|
|
// error
|
|
var unusedLocalProcessor = errorConfig.processors
|
|
.firstWhere((p) => p.appliesTo(unused_local_variable));
|
|
expect(unusedLocalProcessor.severity, ErrorSeverity.ERROR);
|
|
|
|
// skip
|
|
var invalidAssignmentProcessor = errorConfig.processors
|
|
.firstWhereOrNull((p) => p.appliesTo(invalid_assignment));
|
|
expect(invalidAssignmentProcessor, isNull);
|
|
});
|
|
});
|
|
|
|
test('configure lints', () {
|
|
var options = optionsProvider.getOptionsFromString(
|
|
'analyzer:\n errors:\n annotate_overrides: warning\n');
|
|
var errorConfig = ErrorConfig((options['analyzer'] as YamlMap)['errors']);
|
|
expect(errorConfig.processors, hasLength(1));
|
|
|
|
ErrorProcessor processor = errorConfig.processors.first;
|
|
expect(processor.appliesTo(annotate_overrides), true);
|
|
expect(processor.severity, ErrorSeverity.WARNING);
|
|
});
|
|
});
|
|
}
|
|
|
|
late TestContext context;
|
|
|
|
AnalysisOptionsProvider optionsProvider = AnalysisOptionsProvider();
|
|
|
|
void configureOptions(String options) {
|
|
YamlMap optionMap = optionsProvider.getOptionsFromString(options);
|
|
applyToAnalysisOptions(context.analysisOptions, optionMap);
|
|
}
|
|
|
|
ErrorProcessor? getProcessor(AnalysisError error) =>
|
|
ErrorProcessor.getProcessor(context.analysisOptions, error);
|
|
|
|
class TestContext extends AnalysisContextImpl {
|
|
TestContext()
|
|
: super(
|
|
SynchronousSession(
|
|
AnalysisOptionsImpl(),
|
|
DeclaredVariables(),
|
|
),
|
|
_SourceFactoryMock(),
|
|
);
|
|
}
|
|
|
|
class _SourceFactoryMock implements SourceFactory {
|
|
@override
|
|
noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
|
|
}
|