Jonas Termansen bd99509601 [infra] Fix approve_results race condition checking failing on new builders. ...

It would accidentally compare a null old approval map with the new approvals
instead of using an empty map for the old approvals.

While here, remove debug code that shouldn't have been committed.

Change-Id: I071bc6fc830bbb0b0cec310a189c0ef0a46f2bb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98000
Reviewed-by: Alexander Thomas <athom@google.com>

2019-03-27 09:56:22 +00:00

..

abiversions

Reland https://dart-review.googlesource.com/c/sdk/+/96500

2019-03-13 21:03:01 +00:00

android

Cherry-pick 031e77eea1 to the analyzer branch.

2018-11-29 22:14:23 +00:00

apps/update_homebrew

Generate homebrew script compatible with latest changes

2019-01-10 16:43:34 +00:00

bots

[infra] Run pkg/(front_end|kernel) tests only on front-end builders

2019-03-27 08:21:47 +00:00

buildtools

Cherry-pick 031e77eea1 to the analyzer branch.

2018-11-29 22:14:23 +00:00

dart2js

…

dom

New DomExceptions added to browsers.

2019-03-18 15:18:25 +00:00

gardening

Remove unnecessary flags for dart2js from test.dart

2019-03-14 22:01:13 +00:00

infra/config

[infra] Mark gclient-try as non-experimental.

2019-01-25 14:43:09 +00:00

linux_dist_support/debian

[infra] Update debian package metadata

2018-11-07 09:54:46 +00:00

migration

…

patches

[gardening] Clean up outdated flutter hhh patches

2019-03-26 16:38:45 +00:00

sdks

…

spec_parser

Updated spec_parser such that it runs with ANTLR v4

2019-03-19 14:06:26 +00:00

test_generators

…

testing

[gardening] Fix arguments test for app_jit(k).

2019-03-25 16:18:48 +00:00

.gitignore

Reland https://dart-review.googlesource.com/c/sdk/+/96500

2019-03-13 21:03:01 +00:00

3xhead_flutter_hooks.sh

[infra] Extend 3head patching to apply patches for flutter/flutter depending on pinned engine commit

2019-02-04 12:37:10 +00:00

addlatexhash.dart

Cleaned up some terminology, whitespace, and added index.

2018-11-02 12:11:41 +00:00

approve_results.dart

[infra] Fix approve_results race condition checking failing on new builders.

2019-03-27 09:56:22 +00:00

archive_crash.py

…

build.py

Revert "Change default target to "create_sdk"."

2019-01-11 11:50:13 +00:00

canary.dart

…

clean_output_directory.py

…

copy_dart.py

…

copy_tree.py

…

create_debian_chroot.sh

…

create_debian_packages.py

…

create_pkg_manifest.py

[fuchsia] Handle host_{cpu,os} vars in DEPS

2019-01-02 16:17:22 +00:00

create_tarball.py

…

create_timestamp_file.py

…

diff_results.dart

[Gardening] Add tools/diff_results.dart which can query the test results database and report a diff in test results from two commits

2019-03-07 12:50:10 +00:00

download_abi_dills.py

Reland https://dart-review.googlesource.com/c/sdk/+/96500

2019-03-13 21:03:01 +00:00

download_chromium_sysroot.sh

…

download_latest_dev_sdk.py

…

execute_recorded_testcases.py

…

FAKE_COMMITS

[infra] Trigger bots after outage.

2019-01-15 00:31:51 +00:00

find_depot_tools.py

…

gen_fuchsia_test_manifest.py

…

generate_buildfiles.py

…

generate_idefiles.py

[vm] Allow choosing architecture for runtime sources in generate_idefiles.py.

2019-01-11 15:16:34 +00:00

gn_helpers.py

…

gn.py

Cherry-pick 031e77eea1 to the analyzer branch.

2018-11-29 22:14:23 +00:00

line_doc_comments.dart

…

list_dart_files.py

…

list_files.py

…

make_bundle_unittest.py

…

make_version.py

Add use_abi_version flag, and plumb ABI version to version.h

2019-03-05 17:16:11 +00:00

minidump.py

[vm] Integrate dart binary with Crashpad on Windows.

2018-10-24 13:30:16 +00:00

only_in_release_mode.py

…

patch_sdk.dart

Stop using external deprecated members in front_end

2019-01-15 18:55:10 +00:00

presubmit.sh

…

promote.py

[infra] Make promote.py work with newer versions of gsutil

2019-03-06 12:43:07 +00:00

publish_pkg.py

…

revert.py

…

run_debian_build.sh

[infra] Add versionchecker and debianpackage to test matrix

2019-03-11 12:52:03 +00:00

safari_factory_reset.py

…

set_ia32_sysroot.sh

[build] Move to Jessie sysroots from Wheezy sysroots.

2018-10-25 15:05:22 +00:00

set_x64_sysroot.sh

[build] Move to Jessie sysroots from Wheezy sysroots.

2018-10-25 15:05:22 +00:00

spec_parse.py

Updated spec_parser such that it runs with ANTLR v4

2019-03-19 14:06:26 +00:00

status_clean.dart

Remove the Dart 1 tests.

2018-10-11 23:45:18 +00:00

task_kill.py

[Gardening] Kill any leaked flutter_tester processes before/after 3-head builder work

2019-01-03 15:30:11 +00:00

test.dart

[infra] Fall back on inexact baseline commits in test.dart.

2019-03-14 17:04:36 +00:00

test.py

Increase file descriptor limit when running test.py on MacOS

2018-10-16 09:25:10 +00:00

upload_abi_dills.sh

Include gen_kernel_bytecode in create_sdk so that it can be uploaded by the builders

2019-03-19 19:36:59 +00:00

utils.py

[infra] Only move coredump files on shards

2019-03-12 17:43:16 +00:00

VERSION

[vm/bytecode] Declare members in bytecode

2019-03-26 21:40:10 +00:00

write_dartdoc_options_file.py

Add source links to dartdoc output.

2019-02-07 18:46:31 +00:00

write_revision_file.py

…

write_version_file.py

…

yaml2json.dart

…

yaml2json.py

…