Konstantin Shcheglov
9e690bdd06
Keep track of the most recent same-named fragment even when it has a different declaration kind. This lets augmentation validation distinguish between a missing target and a target whose kind does not match the augmentation. Store this information on elements, serialize it through summaries, and use it during error verification. When an augmentation finds a previous declaration with the same name but a different kind, report `augmentationOfDifferentDeclarationKind` and attach a context message that points to the original declaration instead of falling back to `augmentationWithoutDeclaration`. This improves diagnostics for both top-level and member declarations, including combinations such as constructors vs fields, methods vs accessors, and functions vs variables. Change-Id: Ic794c437fa160bb29d25f90559b544a7282ca697 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/494301 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.