Danny Tuppeny
7a6352a9b1
Changes to support DAP in DDS introduced a subtle bug where we could send the `InitializedEvent` before the response to the `Initialize` request because `sendResponse` used a `Completer` and would delay adding the response to the stream until the next iteration of the task queue. Although there were comments stating this order must be preserved, there were no tests that verified this and it breaks VS Code (https://github.com/dart-lang/sdk/issues/52222). I've added tests for this, and changed how this works slightly so instead of using a `Completer` we pass in a "responseWriter" function that must write the response to the stream synchronously. Since the DDS path isn't using events yet and it would require a little more refactoring, I've used a Completer there and added a TODO. Fixes https://github.com/dart-lang/sdk/issues/52222. Change-Id: I1832126f5015b466c721dbda192da4b8a5d83b62 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300601 Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>