Erik Ernst
96a4dd4c19
https://dart-review.googlesource.com/c/sdk/+/498840 added support for promotion of properties (private, final instance variables with a name which isn't used much for other purposes) in the context of anonymous methods. This CL reduces the set of situations where this feature is enabled such that only `this` will allow property promotions to be carried in (such that `this._x` is promoted in `v.=> this._x` when `v` is such that `v._x` has been promoted before the anonymous method occurs). It also generalizes the mechanism such that property promotions are carried out (so we can do `if (v.=> _x is int) v._x.isEven;`). Tests has been adjusted accordingly. Change-Id: Ibe70713d3d9c89a6d95f9c3dd28df8f147cb518d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/502660 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Erik Ernst <eernst@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.