Paul Berry
957c9a1247
The intention of this file was to allow any change to files in `pkg/`
to be approved by anyone in OWNERS_ECOSYSTEM, OWNERS_FOUNDATION, or
OWNERS_INFRA, but that if the package itself specifies other owners,
then those owners should be preferred when suggesting owners.
What was actually happening was that the `#{LAST_RESORT_SUGGESTION}`
annotation only has an effect on lines that name a specific user; it
is ignored on `file:` lines. (See docs at
https://gerrit.googlesource.com/plugins/code-owners/+/refs/heads/master/resources/Documentation/backend-find-owners.md#annotations). So
people in OWNERS_ECOSYSTEM, OWNERS_FOUNDATION, and OWNERS_INFRA were
included in the suggested owners. Fortunately it was not too serious a
problem in practice, because the "find owners" backend seems to have
other heuristics that favor recent reviewers. But it still produced
surprising output when using Gerrit's "suggest all owners" checkbox.
I discussed this with athom@google.com, and we decided to just drop
the `pkg/OWNERS` file altogether.
There was one useful line in that file, assigning `pkg.status` to
OWNERS_ENG. That has been moved to the top level OWNERS file.
Change-Id: I8906ffcd18ffd35055f1401d40a3c3e7fc0eb3a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414183
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
30 lines
1.1 KiB
Plaintext
30 lines
1.1 KiB
Plaintext
# Global approvers - only to be used as a last resort.
|
|
asiva@google.com #{LAST_RESORT_SUGGESTION}
|
|
athom@google.com #{LAST_RESORT_SUGGESTION}
|
|
devoncarew@google.com #{LAST_RESORT_SUGGESTION}
|
|
kustermann@google.com #{LAST_RESORT_SUGGESTION}
|
|
leafp@google.com #{LAST_RESORT_SUGGESTION}
|
|
sigmund@google.com #{LAST_RESORT_SUGGESTION}
|
|
vegorov@google.com #{LAST_RESORT_SUGGESTION}
|
|
vsm@google.com #{LAST_RESORT_SUGGESTION}
|
|
|
|
# DEPS
|
|
per-file DEPS=file:/tools/OWNERS_ENG
|
|
# Updates fuchsia components only.
|
|
per-file DEPS=file:/tools/OWNERS_FUCHSIA
|
|
|
|
# Changelog, AUTHORS, and .git* do not require approval.
|
|
per-file CHANGELOG.md,AUTHORS,WATCHLISTS,.gitattributes,.gitconfig,.gitignore,sdk.code-workspace=*
|
|
|
|
# Product documentation
|
|
per-file CONTRIBUTING.md,LICENSE,PATENT_GRANT,README.*,SECURITY.md,sdk_packages.yaml=file:/tools/OWNERS_PRODUCT
|
|
|
|
# Top level build files
|
|
per-file .clang-format,.gn,BUILD.gn,sdk_args.gni=file:/tools/OWNERS_BUILD
|
|
|
|
# Infrastructure files.
|
|
per-file .style.yapf,codereview.settings,PRESUBMIT.py=file:/tools/OWNERS_INFRA
|
|
|
|
# Test status files
|
|
per-file pkg.status=file:/tools/OWNERS_ENG
|