Siva Annamalai
94c8d341d7
Revert "[vm, gc] Mark through new-space."
...
This reverts commit a3b7c323b0 .
Reason for revert: We are seeing crashes in some internal testing
si_signo=Segmentation fault(11), si_code=SEGV_ACCERR(2), si_addr=0x7f1cadb85bc6
version=3.3.0-edge+google3-v2 (google3) (google3) on "linux_x64"
pid=8967, thread=8969, isolate_group=main(0x5583571aaaf0), isolate=(nil)((nil))
os=linux, arch=x64, comp=no, sim=no
isolate_instructions=7f1cad8b7e40, vm_instructions=7f1cad8b1000
fp=7f1cacc7ebc0, sp=7f1cacc7eb90, pc=5583568155bc
pc 0x00005583568155bc fp 0x00007f1cacc7ebc0 dart::MarkingVisitorBase<true>::VisitPointers(dart::ObjectPtr*, dart::ObjectPtr*)+0x15c
pc 0x0000558356975a1d fp 0x00007f1cacc7ec60 dart::StackFrame::VisitObjectPointers(dart::ObjectPointerVisitor*)+0x1bd
pc 0x0000558356935c29 fp 0x00007f1cacc7ecc0 dart::UntaggedSuspendState::VisitSuspendStatePointers(dart::SuspendStatePtr, dart::ObjectPointerVisitor*)+0x89
pc 0x0000558356815948 fp 0x00007f1cacc7ed10 dart::MarkingVisitorBase<true>::DrainMarkingStackWithPauseChecks()+0x128
pc 0x0000558356815749 fp 0x00007f1cacc7ed80 dart::ConcurrentMarkTask::Run()+0x69
Original change's description:
> [vm, gc] Mark through new-space.
>
> - Initial and final marking no longer visit all of new-space, reducing the STW pause for major GC.
> - A scavenge during concurrent marking must forward / filter objects in the marking worklist that are moved / collected, increasing the STW pause for minor GC.
> - Unreachable intergenerational cycles and weak references are collected in the next mark-sweep instead of first requiring enough scavenges to promote the whole cycle or weak target into old-space.
> - Artificial minor GCs are no longer needed to avoid memory leaks from back-to-back major GCs.
> - reachabilityBarrier is now just a count of major GCs.
>
> TEST=ci
> Change-Id: Ic7754e8d972763654eae2b7faa8670735d9cda3f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340644
> Reviewed-by: Siva Annamalai <asiva@google.com >
> Commit-Queue: Ryan Macnak <rmacnak@google.com >
Change-Id: Ice07b4eb5bef3b41c9618ef0ca7759de006ffe00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343060
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
2023-12-21 21:02:38 +00:00
..
2023-12-21 21:02:38 +00:00
2023-07-10 12:23:15 +00:00
2023-12-21 21:02:38 +00:00
2023-04-17 15:58:28 +00:00
2023-09-13 20:26:30 +00:00
2023-10-11 22:22:12 +00:00
2023-04-20 17:42:06 +00:00
2023-06-06 02:07:58 +00:00
2023-04-10 18:15:12 +00:00
2023-05-24 08:42:14 +00:00
2023-07-03 12:29:15 +00:00
2023-12-21 21:02:38 +00:00
2023-08-10 18:53:37 +00:00
2023-09-05 21:47:59 +00:00
2023-04-21 08:06:49 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-04-12 22:18:54 +00:00
2023-07-11 15:13:58 +00:00
2023-04-12 22:18:54 +00:00
2023-03-06 22:06:59 +00:00
2023-03-06 22:06:59 +00:00
2023-05-10 11:38:57 +00:00
2023-12-15 15:25:29 +00:00
2023-04-12 22:18:54 +00:00
2023-04-10 18:15:12 +00:00
2023-06-28 01:00:18 +00:00
2023-06-28 01:00:18 +00:00
2023-09-13 20:26:30 +00:00
2023-12-12 02:09:27 +00:00
2023-12-15 15:25:29 +00:00
2023-07-26 21:14:09 +00:00
2023-06-15 00:34:18 +00:00
2023-06-21 15:24:30 +00:00
2023-04-20 17:42:06 +00:00
2023-07-27 20:17:17 +00:00
2023-06-28 11:48:26 +00:00
2023-06-28 11:48:26 +00:00
2023-04-10 18:15:12 +00:00
2023-10-12 16:16:21 +00:00
2023-04-12 22:18:54 +00:00
2023-04-10 18:15:12 +00:00
2023-04-12 22:18:54 +00:00
2023-04-10 18:15:12 +00:00
2023-04-12 22:18:54 +00:00
2022-01-20 00:57:57 +00:00
2023-04-10 18:15:12 +00:00
2023-11-28 13:15:56 +00:00
2023-01-20 12:37:49 +00:00
2023-04-10 18:15:12 +00:00
2023-10-12 10:22:38 +00:00
2022-02-22 21:48:14 +00:00
2023-06-28 01:00:18 +00:00
2022-02-22 21:48:14 +00:00
2023-06-28 01:00:18 +00:00
2023-11-30 16:42:28 +00:00
2022-06-08 22:57:03 +00:00
2023-06-28 01:00:18 +00:00
2023-08-01 17:01:41 +00:00
2023-11-30 16:42:28 +00:00
2022-06-08 22:57:03 +00:00
2023-06-28 01:00:18 +00:00
2023-09-04 14:38:27 +00:00
2023-11-28 13:15:56 +00:00
2023-06-23 20:35:00 +00:00
2023-02-27 22:26:36 +00:00
2023-09-12 16:22:19 +00:00
2023-09-12 16:22:19 +00:00
2023-06-23 20:35:00 +00:00
2021-12-16 21:33:49 +00:00
2023-06-23 20:35:00 +00:00
2022-01-20 00:57:57 +00:00
2022-01-20 00:57:57 +00:00
2023-06-23 20:35:00 +00:00
2021-12-16 21:33:49 +00:00
2022-01-20 00:57:57 +00:00
2023-04-10 18:15:12 +00:00
2022-11-14 15:42:52 +00:00
2023-05-22 16:43:04 +00:00
2023-04-10 21:38:57 +00:00
2023-04-10 21:38:57 +00:00
2023-04-10 21:38:57 +00:00
2023-07-12 17:14:18 +00:00
2022-01-20 00:57:57 +00:00
2023-04-10 18:15:12 +00:00
2023-12-21 21:02:38 +00:00
2023-11-30 09:21:04 +00:00
2023-04-20 17:42:06 +00:00
2023-07-26 21:53:49 +00:00
2023-07-20 17:06:44 +00:00
2023-06-29 17:29:48 +00:00
2023-07-27 20:17:17 +00:00
2023-12-05 17:29:05 +00:00
2023-06-29 08:04:20 +00:00
2023-04-12 22:18:54 +00:00
2023-10-12 10:22:38 +00:00
2023-09-06 21:46:00 +00:00
2022-01-20 00:57:57 +00:00
2023-12-14 18:01:32 +00:00
2023-08-31 19:52:23 +00:00
2023-09-27 16:23:38 +00:00
2023-04-10 18:15:12 +00:00
2023-12-14 18:01:32 +00:00
2023-09-27 16:23:38 +00:00
2022-09-12 12:33:57 +00:00
2022-09-12 12:33:57 +00:00
2023-11-07 16:13:11 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2023-10-23 13:54:04 +00:00
2023-05-31 08:06:08 +00:00
2023-11-21 20:39:29 +00:00
2023-08-17 17:38:48 +00:00
2023-04-10 18:15:12 +00:00
2023-09-27 16:23:38 +00:00
2023-09-27 16:23:38 +00:00
2023-11-21 19:14:49 +00:00
2023-11-21 19:14:49 +00:00
2023-12-15 15:25:29 +00:00
2023-12-15 15:25:29 +00:00
2023-08-25 03:35:44 +00:00
2023-04-26 22:18:51 +00:00
2023-07-27 20:17:17 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-08-11 17:56:57 +00:00
2023-04-10 18:15:12 +00:00
2023-09-06 18:10:33 +00:00
2023-10-20 19:45:49 +00:00
2023-07-26 21:53:49 +00:00
2023-10-20 19:45:49 +00:00
2023-02-06 22:19:55 +00:00
2023-04-10 18:15:12 +00:00
2023-06-23 20:35:00 +00:00
2023-06-23 20:35:00 +00:00
2023-04-10 18:15:12 +00:00
2023-04-12 22:18:54 +00:00
2023-04-10 18:15:12 +00:00
2022-01-21 02:02:00 +00:00
2023-06-27 19:42:15 +00:00
2022-12-01 10:15:58 +00:00
2023-12-21 21:02:38 +00:00
2023-05-31 08:06:08 +00:00
2023-11-28 13:15:56 +00:00
2023-04-12 22:18:54 +00:00
2023-11-28 13:15:56 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2022-01-20 00:57:57 +00:00
2023-11-28 13:15:56 +00:00
2023-04-12 22:18:54 +00:00
2023-03-06 22:06:59 +00:00
2023-04-12 22:18:54 +00:00
2022-05-11 19:52:45 +00:00
2022-05-11 19:52:45 +00:00
2023-12-12 02:09:27 +00:00
2023-12-12 02:09:27 +00:00
2023-05-10 19:08:23 +00:00
2023-08-09 06:01:55 +00:00
2023-12-21 21:02:38 +00:00
2023-12-21 21:02:38 +00:00
2023-06-09 17:57:12 +00:00
2023-06-09 17:57:12 +00:00
2023-04-17 15:58:28 +00:00
2023-09-27 13:40:06 +00:00
2023-04-17 15:58:28 +00:00
2023-07-14 10:15:06 +00:00
2023-12-14 18:06:52 +00:00
2023-11-07 14:32:20 +00:00
2023-10-12 10:22:38 +00:00
2023-12-07 11:15:25 +00:00
2023-11-22 16:13:42 +00:00
2022-11-11 01:59:28 +00:00
2023-07-14 10:15:06 +00:00
2023-07-14 10:15:06 +00:00
2023-08-08 10:17:36 +00:00
2023-08-29 16:19:40 +00:00
2023-04-10 18:15:12 +00:00
2022-05-11 19:31:04 +00:00
2023-04-20 17:42:06 +00:00
2023-04-10 18:15:12 +00:00
2023-06-29 08:04:20 +00:00
2023-06-29 08:04:20 +00:00
2023-04-12 22:18:54 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-08-09 06:01:55 +00:00
2023-08-08 10:57:47 +00:00
2023-08-08 10:57:47 +00:00
2023-07-11 10:15:58 +00:00
2022-08-19 18:10:15 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-07-26 21:53:49 +00:00
2023-03-29 19:58:33 +00:00
2023-04-10 18:15:12 +00:00
2023-03-29 19:58:33 +00:00
2023-04-10 18:15:12 +00:00
2023-08-09 06:01:55 +00:00
2023-11-22 16:13:42 +00:00
2023-09-20 16:08:51 +00:00
2023-09-20 16:08:51 +00:00
2023-08-08 10:57:47 +00:00
2023-08-08 10:57:47 +00:00
2023-09-05 21:47:59 +00:00
2023-04-12 22:18:54 +00:00
2023-12-21 21:02:38 +00:00
2023-02-23 03:11:08 +00:00
2023-04-10 18:15:12 +00:00
2023-12-14 22:48:49 +00:00
2023-12-14 22:48:49 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-04-12 22:18:54 +00:00
2023-07-26 21:14:09 +00:00
2022-01-20 00:57:57 +00:00
2023-08-15 17:55:39 +00:00
2023-12-18 21:39:09 +00:00
2023-11-22 16:13:42 +00:00
2023-08-30 17:18:53 +00:00
2023-12-21 21:02:38 +00:00
2023-12-15 15:25:29 +00:00
2023-12-14 16:33:21 +00:00
2023-12-07 17:42:19 +00:00
2023-11-16 18:24:38 +00:00
2023-11-16 18:24:38 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2022-03-10 23:48:05 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-10-12 16:58:27 +00:00
2023-09-28 19:53:33 +00:00
2023-11-17 19:11:57 +00:00
2023-06-12 15:26:29 +00:00
2023-12-18 21:39:09 +00:00
2023-08-04 11:07:46 +00:00
2022-06-02 23:39:45 +00:00
2022-06-02 23:39:45 +00:00
2023-12-15 16:48:37 +00:00
2022-09-27 21:34:05 +00:00
2023-04-12 22:18:54 +00:00
2023-08-09 06:01:55 +00:00
2023-08-09 06:01:55 +00:00
2023-08-09 06:01:55 +00:00
2023-04-10 18:15:12 +00:00
2023-08-17 18:51:19 +00:00
2023-08-17 18:51:19 +00:00
2023-10-02 17:57:33 +00:00
2023-12-05 17:29:05 +00:00
2023-08-17 18:51:19 +00:00
2023-04-19 08:47:31 +00:00
2023-04-10 18:15:12 +00:00
2023-08-01 15:50:11 +00:00
2023-09-06 18:11:58 +00:00
2022-12-01 14:38:44 +00:00
2023-12-21 21:02:38 +00:00
2023-12-21 21:02:38 +00:00
2023-11-27 15:22:40 +00:00
2023-04-12 22:18:54 +00:00
2023-10-17 16:14:29 +00:00
2023-04-10 18:15:12 +00:00
2023-04-12 22:18:54 +00:00
2023-04-10 18:15:12 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2023-11-27 15:22:40 +00:00
2023-11-27 15:22:40 +00:00
2023-07-06 21:10:28 +00:00
2023-04-12 22:18:54 +00:00
2023-04-10 18:15:12 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2022-12-29 10:18:02 +00:00
2023-04-12 22:18:54 +00:00
2023-12-15 15:25:29 +00:00
2023-08-30 17:18:53 +00:00
2023-04-10 18:15:12 +00:00
2021-12-16 10:39:49 +00:00
2021-12-16 10:39:49 +00:00
2023-04-12 22:18:54 +00:00
2022-03-22 19:45:03 +00:00
2022-03-22 19:45:03 +00:00
2022-03-22 19:45:03 +00:00
2023-09-11 21:25:09 +00:00
2022-03-22 19:45:03 +00:00
2022-03-22 19:45:03 +00:00
2023-12-21 21:02:38 +00:00
2023-06-28 01:00:18 +00:00
2023-04-10 18:15:12 +00:00
2023-08-24 15:21:51 +00:00
2023-10-04 13:18:55 +00:00
2023-08-21 16:46:46 +00:00
2023-06-29 08:04:20 +00:00
2023-04-10 18:15:12 +00:00
2023-11-14 16:13:59 +00:00
2023-11-14 16:13:59 +00:00
2023-11-14 16:13:59 +00:00
2023-09-27 15:11:05 +00:00
2023-06-23 17:01:58 +00:00
2023-01-06 07:48:22 +00:00
2023-09-27 15:11:05 +00:00
2023-07-21 19:06:43 +00:00
2023-07-21 19:06:43 +00:00
2023-07-21 19:06:43 +00:00
2023-07-21 19:06:43 +00:00
2023-07-11 15:13:58 +00:00
2023-04-12 22:18:54 +00:00
2023-07-11 15:13:58 +00:00
2023-04-12 22:18:54 +00:00
2022-07-29 18:11:01 +00:00
2023-04-12 22:18:54 +00:00
2023-04-10 18:15:12 +00:00
2023-04-12 22:18:54 +00:00
2023-09-19 21:53:41 +00:00
2023-09-19 21:53:41 +00:00
2023-09-19 21:53:41 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2023-04-28 23:25:43 +00:00
2023-04-12 22:18:54 +00:00
2023-10-20 19:45:49 +00:00
2023-04-12 22:18:54 +00:00
2023-08-31 11:47:54 +00:00
2023-06-30 14:03:03 +00:00
2022-03-22 19:45:03 +00:00
2022-03-22 19:45:03 +00:00
2022-03-22 19:45:03 +00:00
2023-07-03 10:39:53 +00:00
2022-03-22 19:45:03 +00:00
2022-03-22 19:45:03 +00:00
2023-08-15 14:54:58 +00:00
2023-07-03 10:39:53 +00:00
2023-04-19 08:47:31 +00:00
2023-12-15 15:25:29 +00:00
2023-12-21 21:02:38 +00:00
2023-08-17 18:51:19 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2021-11-02 17:42:52 +00:00
2023-09-27 15:11:05 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-02-21 19:07:57 +00:00
2023-10-09 17:23:23 +00:00
2023-09-27 15:11:05 +00:00
2023-09-27 15:11:05 +00:00
2023-04-10 18:15:12 +00:00
2023-03-06 22:06:59 +00:00
2023-01-09 15:48:57 +00:00
2023-12-21 21:02:38 +00:00
2023-12-21 21:02:38 +00:00
2023-05-10 19:08:23 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-11-21 11:46:24 +00:00
2023-12-21 21:02:38 +00:00
2023-12-21 21:02:38 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-07-10 20:33:33 +00:00
2023-10-16 14:02:31 +00:00
2023-10-12 16:58:27 +00:00
2023-12-18 17:01:18 +00:00
2021-12-15 23:12:19 +00:00
2023-02-20 14:57:57 +00:00
2023-09-27 16:23:38 +00:00
2023-09-27 16:23:38 +00:00
2023-06-24 12:56:12 +00:00
2023-08-15 14:54:58 +00:00
2023-04-17 16:26:35 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2023-04-12 22:18:54 +00:00
2023-11-28 13:15:56 +00:00
2023-11-28 13:15:56 +00:00
2023-11-21 20:39:29 +00:00
2023-11-21 20:39:29 +00:00
2023-05-11 03:14:27 +00:00
2023-04-10 18:15:12 +00:00
2023-04-10 18:15:12 +00:00
2023-10-31 19:39:51 +00:00
2021-12-15 22:22:36 +00:00
2022-08-05 11:53:37 +00:00
2023-06-23 20:35:00 +00:00
2023-06-23 20:35:00 +00:00
2023-10-17 20:32:52 +00:00
2023-08-11 21:30:17 +00:00
2023-11-03 07:36:25 +00:00
2023-06-21 11:39:50 +00:00
2023-11-01 22:38:27 +00:00
2023-06-20 19:28:18 +00:00
2022-09-10 15:12:35 +00:00
2023-04-21 22:41:28 +00:00
2023-09-05 21:47:59 +00:00
2023-06-07 19:01:51 +00:00
2023-06-16 11:22:38 +00:00
2023-06-16 11:22:38 +00:00