Paul Berry
94b953305a
Previously, when the code in `parser_ast_indexer.dart` encountered a constructor, it assumed that it could figure out the constructor's name by looking at the last identifier (before parameters) of the signature, and prepending the class name with a `.`. This had the side effect that "unnamed" constructors were given a name of `ClassName.ClassName`. With the new constructor syntax, this doesn't work anymore, because for unnamed constructors the signature looks like `new(...parameters...)` or `factory(...parameters...)`, so there are no identifiers, leading to a crash. At the moment we don't see the crash because this code is only used to analyze files within the front end and kernel, which don't use the new constructor syntax yet. But it blocks us from being able to migrate the front end and kernel to use the new constructor syntax. This CL fixes the problem, unblocking the migration. Change-Id: Ibf78b77d736ab2ec812945401ffacf3f6a6a6964 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/507261 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. It's very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency
Adding new packages
Run gclient sync to re-generate .dart_tool/package_config.json after adding
a new package.
Testing packages
Currently dart test can't be used to run the tests, use test.py as usual.
E.g. the command ./tools/test.py -n...<path> runs all tests with prefix
<path>.