Vyacheslav Egorov
3b86f823d0
GrowableArrayMarker was a class that implemented int and was used to
enable implementation of default List factory constructor in pure Dart:
factory List([int length = GROWABLE_ARRAY_MARKER]) {
return identical(length, GROWABLE_ARRAY_MARKER) ? new _GrowableList<E>(0)
: new _List<E>(length);
}
Its existence complicated all kinds of things in the VM and it is finally
time to remove it.
Instead we build List factory body directly in IL.
This CL also provides inlining rule for `new List(n)` case.
Change-Id: I870751658a4ac17fce649c9ac70395ff88a5436c
Reviewed-on: https://dart-review.googlesource.com/57262
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
64 lines
1.8 KiB
Dart
64 lines
1.8 KiB
Dart
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
|
|
// for details. All rights reserved. Use of this source code is governed by a
|
|
// BSD-style license that can be found in the LICENSE file.
|
|
|
|
// part of "core_patch.dart";
|
|
|
|
@patch
|
|
class List<E> {
|
|
@patch
|
|
factory List([int length]) native "List_new";
|
|
|
|
@patch
|
|
factory List.filled(int length, E fill, {bool growable: false}) {
|
|
// All error handling on the length parameter is done at the implementation
|
|
// of new _List.
|
|
var result = growable ? new _GrowableList<E>(length) : new _List<E>(length);
|
|
if (fill != null) {
|
|
for (int i = 0; i < length; i++) {
|
|
result[i] = fill;
|
|
}
|
|
}
|
|
return result;
|
|
}
|
|
|
|
@patch
|
|
factory List.from(Iterable elements, {bool growable: true}) {
|
|
if (elements is EfficientLengthIterable) {
|
|
int length = elements.length;
|
|
var list = growable ? new _GrowableList<E>(length) : new _List<E>(length);
|
|
if (length > 0) {
|
|
// Avoid creating iterator unless necessary.
|
|
int i = 0;
|
|
for (var element in elements) {
|
|
list[i++] = element;
|
|
}
|
|
}
|
|
return list;
|
|
}
|
|
List<E> list = new _GrowableList<E>(0);
|
|
for (E e in elements) {
|
|
list.add(e);
|
|
}
|
|
if (growable) return list;
|
|
return makeListFixedLength(list);
|
|
}
|
|
|
|
@patch
|
|
factory List.unmodifiable(Iterable elements) {
|
|
final result = new List<E>.from(elements, growable: false);
|
|
return makeFixedListUnmodifiable(result);
|
|
}
|
|
|
|
// Factory constructing a mutable List from a parser generated List literal.
|
|
// [elements] contains elements that are already type checked.
|
|
factory List._fromLiteral(List elements) {
|
|
if (elements.isEmpty) {
|
|
return new _GrowableList<E>(0);
|
|
}
|
|
var result = new _GrowableList<E>.withData(elements);
|
|
result._setLength(elements.length);
|
|
return result;
|
|
}
|
|
}
|