Paul Berry
8fbb5bbf5b
This logic allowed the analyzer to omit consideration of type parameter bounds during execution of the `matchSupertypeConstraints` method (which is used for mixin type parameter inference). I added it back in 2018 (https://dart-review.googlesource.com/c/sdk/+/44220) in an attempt to fix #32353, however after I made the fix, additional work by the front end team made it seem like I had probably misunderstood the issue. In any case, I've verified with both SDK trybots and an internal presubmit that removing this logic doesn't break anything, so I believe it's likely that the bug was later fixed in a different (and presumably more correct) fashion. I'm currently doing work on the analyzer's type inference logic, and GenericInferrer.considerExtendsClause is complicating my efforts, so it seems reasonable to remove it at this point. Change-Id: Ia0a988c7297e1579c2e96f9fa886e280f47ab62e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237003 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Package validation
The packages in pkg/ are automatically validated on the LUCI CI bots. The
validation is largely done by the tools/package_deps package; it can be tested
locally via:
dart tools/package_deps/bin/package_deps.dart
Packages which are published
There are several packages developed in pkg/ which are published to pub.
Validation of these packages is particularly important because the pub tools are
not used for these packages during development; we get our dependency versions
from the DEPS file. Its very easy for the dependencies specified in a package's
pubspec file to get out of date wrt the packages and versions actually used.
In order to better ensure we're publishing correct packages, we validate some properties of the pubspec files on our CI system. These validations include:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that we don't use relative path deps to pkg/ or third_party/ packages
Packages which are not published
For packages in pkg/ which we do not intend to be published, we put the following comment in the pubspec.yaml file:
# This package is not intended for consumption on pub.dev. DO NOT publish.
publish_to: none
These pubspecs are still validated by the package validation tool. The contents are more informational as the pubspecs for these packages are not consumed by the pub tool or ecosystem.
We validate:
- that the dependencies listed in the pubspec are used in the package
- that all the packages used by the source are listed in the pubspec
- that a reference to a pkg/ package is done via a relative path dependency