375dc2889b
This reverts commitbca8a053e6. Reason for revert: Issue found, fixed in this CL (by closing a file sink).. Original change's description: > Revert "Emit empty symbols file under --emit-debug-symbols flag" > > This reverts commitb666964948. > > Reason for revert: <Broke pkg-win-release bot, investigating> > > Original change's description: > > Emit empty symbols file under --emit-debug-symbols flag > > > > Towards: https://github.com/dart-lang/sdk/issues/40273: > > Change-Id: I9e735d7e77588ab6bc1c7e30176e2d96a0265a13 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202731 > > Reviewed-by: Nicholas Shahan <nshahan@google.com> > > Commit-Queue: Anna Gringauze <annagrin@google.com> > > TBR=sigmund@google.com,nshahan@google.com,annagrin@google.com > > Change-Id: I4b26c26b6404519a1b46c1eca919455cb60ca5e8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202869 > Reviewed-by: Anna Gringauze <annagrin@google.com> > Reviewed-by: Nicholas Shahan <nshahan@google.com> > Commit-Queue: Anna Gringauze <annagrin@google.com> Change-Id: Iaba56e82a5c5500437b98c3f69066a2f53f6ee4e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203000 Reviewed-by: Nicholas Shahan <nshahan@google.com> Reviewed-by: Anna Gringauze <annagrin@google.com> Commit-Queue: Anna Gringauze <annagrin@google.com>
The frontend_server package is used by both the flutter command line tool and the frontend_server_client package (used by webdev and package:test).
API Stability
Changes to the command line API or behavior should be tested against the follwing test suites (in addition to normal HHH testing):
- flutter_tools: https://github.com/flutter/flutter/tree/master/packages/flutter_tools
- frontend_server_client: https://github.com/dart-lang/webdev/tree/master/frontend_server_client
Otherwise these changes will need to be carefully coordinated with the flutter tooling and frontend_server_client teams.
This API stability does not cover any of the source code APIs.
Stable subset
- The frontend_server kernel compilation and expression evaluation for kernel should be considered "stable".
- The frontend_server JavaScript compilation is semi-stable, but clients should anticipate coordinated breaking changes in the future.
- The frontend_server JavaScript expression evaluation is experimental and is expected to change significantly from Dec 2020 through the end of 2021.
- Specific flags like the --flutter-widget-cache may be added for experimentation and should not be considered stable.